Skip to content

Frontend/Enable cosmetology - #1862

Merged
isabeleliassen merged 1 commit into
csg-org:mainfrom
InspiringApps:frontend/enable-cosmo-prod
Aug 27, 2026
Merged

Frontend/Enable cosmetology#1862
isabeleliassen merged 1 commit into
csg-org:mainfrom
InspiringApps:frontend/enable-cosmo-prod

Conversation

@jsandoval81

@jsandoval81 jsandoval81 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Requirements List

  • FE: None
  • BE: Infra deployed + SSM parameters

Description List

  • Enable Cosmetology in production

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review

Closes #1859

Summary by CodeRabbit

  • New Features

    • Enabled the Cosmetology compact in all environments, including production.
  • Bug Fixes

    • Corrected compact availability behavior so Cosmetology remains accessible in production while Social Work retains its existing environment-specific availability.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b410551-5784-4102-a8cb-2e52dfabc28e

📥 Commits

Reviewing files that changed from the base of the PR and between e44476f and 7a4265d.

📒 Files selected for processing (3)
  • webroot/src/plugins/Compacts/compacts.spec.ts
  • webroot/src/utils/compactConfig.spec.ts
  • webroot/src/utils/compactConfig.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The COSMETOLOGY compact is now enabled in all environments, including production. Tests separate COSMETOLOGY behavior from SOCIAL_WORK production gating and update the expected results.

Changes

Cosmetology production enablement

Layer / File(s) Summary
Enable COSMETOLOGY and validate environment behavior
webroot/src/utils/compactConfig.ts, webroot/src/utils/compactConfig.spec.ts, webroot/src/plugins/Compacts/compacts.spec.ts
The COSMETOLOGY predicate now always returns true. Tests expect COSMETOLOGY to remain enabled in production and SOCIAL_WORK to remain disabled there.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7a426

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: enabling Cosmetology in the frontend.
Description check ✅ Passed The description includes the required sections, describes the production enablement, lists the standard testing requirements, and references issue #1859.
Linked Issues check ✅ Passed The changes satisfy issue #1859 by enabling the COSMETOLOGY compact in production and updating the related tests.
Out of Scope Changes check ✅ Passed All changes are limited to enabling the COSMETOLOGY compact and updating its production-enablement tests. No unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jsandoval81

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jsandoval81
jsandoval81 requested a review from jlkravitz August 26, 2026 22:04
@jsandoval81

Copy link
Copy Markdown
Collaborator Author

@jlkravitz This is ready for your review.

@jlkravitz jlkravitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge!

@isabeleliassen
isabeleliassen merged commit b71b004 into csg-org:main Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Cosmetology in Prod FE

3 participants