native assets migration - #11
Merged
Merged
Conversation
sneurlax
force-pushed
the
native-assets
branch
from
September 10, 2026 21:08
8acf950 to
360a31f
Compare
julian-CStack
marked this pull request as ready for review
September 10, 2026 21:31
Member
|
Tested working on linux just now, post latest cherrypicked commits. Will report back re: Windows then approve/request changes |
Its build paths under .dart_tool exceed MAX_PATH, breaking every Windows build. openssl is unused here and has no other Windows consumer (native-tls uses SChannel); other targets are unchanged. The hook now fails fast on Windows to Unix cross-compiles, which OpenSSL's Configure rejects anyway.
sneurlax
approved these changes
Sep 10, 2026
sneurlax
left a comment
sneurlax
left a comment
Member
There was a problem hiding this comment.
Tested working on Linux and Android on Linux and Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP?