feat: Use appjail-template(5) for allow.* parameters - #26
Merged
Conversation
Currently, `allow.*` parameters are only set in a `Makejail`, which is used exclusively by Director. If a user deploys an OCI container using `appjail oci run` (CLI), the service may fail to start or may not work as expected due to the absence of the `allow.*` parameters. `allow.*` parameters are set using the `SET` instruction in a `Makejail`, but an easier way is through an `appjail-template(5)`, which can be used by both Director and the CLI, allowing the same template to be reused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
allow.*parameters are only set in aMakejail, which is used exclusively by Director. If a user deploys an OCI container usingappjail oci run(CLI), the service may fail to start or may not work as expected due to the absence of theallow.*parameters.allow.*parameters are set using theSETinstruction in aMakejail, but an easier way is through anappjail-template(5), which can be used by both Director and the CLI, allowing the same template to be reused.