Skip to content

chore(storybook): drop fake stats and placeholder copy from the snapshot and milestone stories - #6636

Closed
idoshamun wants to merge 1 commit into
mainfrom
chore/storybook-no-fake-stats
Closed

chore(storybook): drop fake stats and placeholder copy from the snapshot and milestone stories#6636
idoshamun wants to merge 1 commit into
mainfrom
chore/storybook-no-fake-stats

Conversation

@idoshamun

@idoshamun idoshamun commented Sep 10, 2026

Copy link
Copy Markdown
Member

What and why

This repo is public, and several Storybook stories read as facts: what share of daily.dev readers reach each streak day, which real brands give daily.dev readers which deals (and what daily.dev earns per claim), and what real daily.dev members scored. None of it is true, and a story is a bad place to be wrong about readers, real people or real brands. This PR removes that content outright instead of swapping in other numbers or placeholder text. Storybook only, no production code.

Removed, per file

milestone-rewards/

  • data.ts: the rarity field and every value, the unused subhead field (it carried "Top 4% of everyone reading on daily.dev" and a "1 in 500 readers" line), the whole partner offer catalogue (Offer, offers, offerList, OfferCategory, per-claim payout), firstPartyRewards and mystery (only the deleted files used them), and the header comment describing the catalogue as a partner network.
  • Deleted, because they only existed to show those offers: coupons.tsx, Coupons.stories.tsx, RewardCard.tsx, RewardCards.stories.tsx, ClaimSheet.tsx, ClaimFlow.stories.tsx, GiftVault.tsx, QuietGift.tsx, SupportingSurfaces.stories.tsx, VariantSplit.tsx, VariantLadder.tsx, VariantCarousel.tsx, VariantMobile.tsx, VariantSpotlight.tsx, Variants.stories.tsx.
  • moment.tsx: GiftHeadline, DeclineStyle and SaveForLater, which only the deleted gift popups used. FlameBadge, FlameSize, TierName, DayStrip, EmberPanel and NoThanks keep their names and props.
  • StreakDays.stories.tsx: the "Who sees it" rarity column and the "realistically two" line.
  • Final.stories.tsx: the Popups and States stories, the gift and claim sections of the phone story, the "partner catalogue, verbatim" decision and the "which desktop shape ships" callout. Stories renumbered.
  • Overview.stories.tsx: the rendered offer popup, the variant table that pointed at the deleted stories, the brand catalogue callout, and brand names with invented deals from the rules and copy-voice callouts.

features/snapshot/

  • snapshotFixtures.ts: the inlined photo of a real member (BOBBY_AVATAR); PROFILE_USER is now a fictional member.
  • ShareImages.stories.tsx: real members (leaderboard row, profile, watercooler, discussion, award, briefing) replaced with fictional ones drawn with avatarUri; invented quotes credited to a fictional source instead of a real creator and a real publication; the post's view, upvote and comment counts; the tag's follower count; the best-of upvote totals; the rarity pill on a real achievement; an invented bio; the invented "month of Plus" referral perk. The invite headline is now the product's real labels.referral.generic.inviteText.
  • SnapshotEdgeCases.stories.tsx: the same swaps and removals, plus a streak milestone line that made a claim about daily.dev's age.
  • surfaces/FeedAndLists.stories.tsx: a real member's name and handle on the hot take modal.
  • surfaces/CopyMyFeed.stories.tsx: a real teammate's name as the feed sharer.
  • surfaces/InviteOnboarding.stories.tsx: the invented "Invite 3 friends, get a month of Plus" offer; the step now uses the real "Invite friends" copy from ReferralWidget.

Kept on purpose

  • Inputs a card needs to render for a fictional member or item: levels, XP, reputation, streak lengths, award counts, reactions on fictional hot takes, the rarity pill on a fictional achievement, and the long overflow prose in the edge cases.
  • The streak ladder, tier art, first-party rewards, freeze, broken-streak and no-offer popups, and the sponsored-gift design rationale that names no brand and states no reader numbers.
  • Real news posts (the CD Projekt Red and Qwen items match the published coverage), with their engagement counts removed.
  • The proposed kill thresholds in the milestone overview's "What we measure" table. They are targets, not measurements.
  • Files outside this scope, including surfaces/Overview, StatusMoments, SnapshotPlacements, Briefing, HappeningNow and Profile, which open PRs are already changing. StatusMoments from feat(snapshot): status moments review page #6581 still compiles against the trimmed data.ts and moment.tsx.

Testing

  • npx tsc --noEmit -p tsconfig.json in packages/storybook: nothing reported under milestone-rewards or features/snapshot, and the error count is unchanged from main. feat(snapshot): status moments review page #6581's StatusMoments.stories.tsx also compiles against this branch.
  • Prettier is clean on the changed files.
  • Rendered every remaining milestone-rewards story plus Share images, Edge cases, Share my feed, Hot takes & history and Invite onboarding in local Storybook with no console errors. "Generate all" on Share images produced all 21 PNGs.

Preview domain

https://chore-storybook-no-fake-stats.preview.app.daily.dev

…hot and milestone stories

This repo is public, and these stories read as facts: how many daily.dev
readers reach a streak day, which brands give daily.dev readers which deals,
and what real daily.dev members scored.

Milestone rewards: remove the rarity field and its column, the audience
subheads, and the whole partner offer catalogue (real brands with invented
deals and invented per-claim payouts). The stories that only existed to show
those offers go with it: coupons, reward cards, the claim sheet and flow, the
gift vault and toasts, and the popup variants. The streak ladder, the tier
art, the first-party, freeze, broken-streak and no-offer popups stay, and
moment.tsx keeps every export the status moments page imports.

Snapshot: replace real members (and the inlined photo of one) with
fictional identities drawn with avatarUri, credit invented quotes to a
fictional source instead of real publications, and drop the audience
counts on real entities (tag followers, list upvote totals, a post's
impressions), the rarity pill on a real achievement, and an invented
"month of Plus" referral perk. The invite cards now use the product's real
referral string.
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
daily-webapp Ready Ready Preview Sep 10, 2026 1:28pm UTC

Request Review

@idoshamun

Copy link
Copy Markdown
Member Author

Closing: the ask is limited to what is wired into the product, and this only changed Storybook mock data.

@idoshamun idoshamun closed this Sep 10, 2026
@idoshamun
idoshamun deleted the chore/storybook-no-fake-stats branch September 10, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant