chore(storybook): drop fake stats and placeholder copy from the snapshot and milestone stories - #6636
Closed
idoshamun wants to merge 1 commit into
Closed
chore(storybook): drop fake stats and placeholder copy from the snapshot and milestone stories#6636idoshamun wants to merge 1 commit into
idoshamun wants to merge 1 commit into
Conversation
…hot and milestone stories This repo is public, and these stories read as facts: how many daily.dev readers reach a streak day, which brands give daily.dev readers which deals, and what real daily.dev members scored. Milestone rewards: remove the rarity field and its column, the audience subheads, and the whole partner offer catalogue (real brands with invented deals and invented per-claim payouts). The stories that only existed to show those offers go with it: coupons, reward cards, the claim sheet and flow, the gift vault and toasts, and the popup variants. The streak ladder, the tier art, the first-party, freeze, broken-streak and no-offer popups stay, and moment.tsx keeps every export the status moments page imports. Snapshot: replace real members (and the inlined photo of one) with fictional identities drawn with avatarUri, credit invented quotes to a fictional source instead of real publications, and drop the audience counts on real entities (tag followers, list upvote totals, a post's impressions), the rarity pill on a real achievement, and an invented "month of Plus" referral perk. The invite cards now use the product's real referral string.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Closing: the ask is limited to what is wired into the product, and this only changed Storybook mock data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This repo is public, and several Storybook stories read as facts: what share of daily.dev readers reach each streak day, which real brands give daily.dev readers which deals (and what daily.dev earns per claim), and what real daily.dev members scored. None of it is true, and a story is a bad place to be wrong about readers, real people or real brands. This PR removes that content outright instead of swapping in other numbers or placeholder text. Storybook only, no production code.
Removed, per file
milestone-rewards/data.ts: therarityfield and every value, the unusedsubheadfield (it carried "Top 4% of everyone reading on daily.dev" and a "1 in 500 readers" line), the whole partner offer catalogue (Offer,offers,offerList,OfferCategory, per-claimpayout),firstPartyRewardsandmystery(only the deleted files used them), and the header comment describing the catalogue as a partner network.coupons.tsx,Coupons.stories.tsx,RewardCard.tsx,RewardCards.stories.tsx,ClaimSheet.tsx,ClaimFlow.stories.tsx,GiftVault.tsx,QuietGift.tsx,SupportingSurfaces.stories.tsx,VariantSplit.tsx,VariantLadder.tsx,VariantCarousel.tsx,VariantMobile.tsx,VariantSpotlight.tsx,Variants.stories.tsx.moment.tsx:GiftHeadline,DeclineStyleandSaveForLater, which only the deleted gift popups used.FlameBadge,FlameSize,TierName,DayStrip,EmberPanelandNoThankskeep their names and props.StreakDays.stories.tsx: the "Who sees it" rarity column and the "realistically two" line.Final.stories.tsx: the Popups and States stories, the gift and claim sections of the phone story, the "partner catalogue, verbatim" decision and the "which desktop shape ships" callout. Stories renumbered.Overview.stories.tsx: the rendered offer popup, the variant table that pointed at the deleted stories, the brand catalogue callout, and brand names with invented deals from the rules and copy-voice callouts.features/snapshot/snapshotFixtures.ts: the inlined photo of a real member (BOBBY_AVATAR);PROFILE_USERis now a fictional member.ShareImages.stories.tsx: real members (leaderboard row, profile, watercooler, discussion, award, briefing) replaced with fictional ones drawn withavatarUri; invented quotes credited to a fictional source instead of a real creator and a real publication; the post's view, upvote and comment counts; the tag's follower count; the best-of upvote totals; the rarity pill on a real achievement; an invented bio; the invented "month of Plus" referral perk. The invite headline is now the product's reallabels.referral.generic.inviteText.SnapshotEdgeCases.stories.tsx: the same swaps and removals, plus a streak milestone line that made a claim about daily.dev's age.surfaces/FeedAndLists.stories.tsx: a real member's name and handle on the hot take modal.surfaces/CopyMyFeed.stories.tsx: a real teammate's name as the feed sharer.surfaces/InviteOnboarding.stories.tsx: the invented "Invite 3 friends, get a month of Plus" offer; the step now uses the real "Invite friends" copy fromReferralWidget.Kept on purpose
surfaces/Overview,StatusMoments,SnapshotPlacements,Briefing,HappeningNowandProfile, which open PRs are already changing.StatusMomentsfrom feat(snapshot): status moments review page #6581 still compiles against the trimmeddata.tsandmoment.tsx.Testing
npx tsc --noEmit -p tsconfig.jsoninpackages/storybook: nothing reported undermilestone-rewardsorfeatures/snapshot, and the error count is unchanged frommain. feat(snapshot): status moments review page #6581'sStatusMoments.stories.tsxalso compiles against this branch.Preview domain
https://chore-storybook-no-fake-stats.preview.app.daily.dev