chore(snapshot): remove share cards with no product placement - #6637
Merged
Conversation
#6544 landed fourteen designed cards, but only the profile, achievement, reading overview, badges, list and highlight cards are wired into the product by the open follow-ups. Award, level up, discussion, tag/source/ squad, invite, leaderboard, post and streak have no placement in the product or in any open PR, so they are removed along with the level ring only two of them used. They can come back with the surface that mounts them. Storybook drops the gallery entries and edge cases for the removed cards, the fixtures only those entries used, and a real member's photo that was inlined as a fixture.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6544 added fourteen designed share cards. Once the open follow-ups land, six of them are wired into the product: profile, reading overview, badges and awards, achievements, single achievement (#6580), and list (the briefing's Must know, #6563). Highlight text already powers the post page.
The rest have no placement in the product or in any open PR, so they are removed rather than shipped as dead code:
AwardSnapshotCard,CelebrationSnapshotCard(level up),DiscussionSnapshotCard,EntitySnapshotCard(tag, source, squad),InviteSnapshotCard,LeaderboardSnapshotCard,PostSnapshotCard,StreakSnapshotCardSnapshotLevelRing, which only the leaderboard and level up cards usedEach can come back with the surface that mounts it.
Storybook: the Share images gallery and Edge cases drop the entries for the removed cards, plus the fixtures only those entries used, including a real member's photo inlined as a fixture.
Events
None.
Experiment
None.
Testing
typecheck-strict-changedclean, eslint clean onfeatures/snapshot, snapshot and post specs pass (33 suites, 208 tests), full webapptscclean apart from the known__tests__backlog.tscclean for the snapshot stories.Preview domain
https://chore-remove-unwired-snapshot-ca.preview.app.daily.dev