feat(share): add Slack to the share bands - #6639
Open
idoshamun wants to merge 1 commit into
Open
Conversation
#6627 added Slack to the share surfaces, but the end-of-thread band and the post-upvote prompt came in parallel through #6556 and render their networks from ShareActions, which never handed SocialShareList a post. The list only offers Slack when it has one, since a Slack share is post-scoped, so the bands showed every network but Slack. ShareActions and ShareBand now take the post and origin and forward them; both bands pass theirs, so the Slack share logs where it started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6627 added Slack to the share surfaces. The two share bands from #6556 (the end-of-thread band and the post-upvote prompt) landed in parallel and build their network list through
ShareActions, which never passed a post toSocialShareList. The list only offers Slack when it has a post, so the bands showed every network except Slack.ShareActionsandShareBandnow acceptpostandoriginand forward them.EndOfThreadShareandPostContentSharepass theirs, so the Slack button appears behind the band's chevron and itsstart share to slackevent carries the band's origin (end of conversation,post content).The briefing's end band in #6563 uses
ShareBandtoo; once this lands, it gets Slack by passing the brief post.Events
No new events. Slack's existing
start share to slacknow also fires from the two bands, with their origins.Experiment
None.
Testing
ShareActionstest: Slack is offered only when a post is passed.typecheck-strict-changedclean, eslint clean, full webapptscclean apart from the known__tests__backlog.Preview domain
https://feat-share-band-slack.preview.app.daily.dev