Skip to content

Critical important: fix a mistake after the yesterday doed selective merge with definitions.yaml and definitions.rs test file related #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NSoiffer merged 1 commit into from
Aug 17, 2026
Merged

Critical important: fix a mistake after the yesterday doed selective merge with definitions.yaml and definitions.rs test file related #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Rules/Languages/hu/definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@
#"fraction":"function=fraction; over; end fraction", # NOTE: Fails
"mixed-fraction":"infix=és", # NOTE: in website says function, but follow infix speech pattern.
"greatest-common-divisor": "function=a legnagyobb közös osztó",
"quotient":"function=egész rész osztva", # NOTE: Logic somewhere here failing, becomes "divided by of x comma, y" instead of "integer part of x divided by y"
"quotient":"function=egész rész | osztva", # NOTE: Logic somewhere here failing, becomes "divided by of x comma, y" instead of "integer part of x divided by y"
"evaluated-at":"infix=értékelve || postfix=értékként",
"remainder":"function=a maradék, osztva",
"remainder":"function=a maradék | osztva",
"max":"function=max",
"min":"function=min",
"power":"infix=a hatványra",
"root":"function=root",
"imaginary-part": "a képzeletbeli rész",
"imaginary-part": "function=a képzeletbeli rész: a képzeletbeli rész: a képzeletbeli rész",
"least-common-multiple": "function=lcm: a legkisebb közös többszörös: a legkisebb közös többszörös",
"complex-conjugate":"function=Komplex konjugált",
"complex-arg":"function=argumentum",
Expand Down Expand Up @@ -131,15 +131,15 @@
"tends-to-from-below":"infix=alulról indul",
### Sets
"set": "function= ; halmaz: a halmaz",
"set-difference":"function=különbséghalmaz || infix=mínusz || postfix=különbséghalmaza", # NOTE: not tested
"set-difference":"function=különbséghalmaz | és || infix=mínusz",
"complement":"function=komplemens",
"empty-set":"function=üres halmaz",
"empty-set":"nofix=üres halmaz",
"cardinality":"function=számosság", # NOTE: does not have a defined speech template in website
"list":"function=lista",
"tuple": "function= ; tuple: a tuple",
### Sequence and Series
"sum":"function= ; összegzés : összeg ; ", #: sum over : sum from; to",
"product":"function=szorzat || function=szorzat vége || function=szorzat innen ide",
"sum": "function=összeg",
"product":"function=szorzat",

### Elementary classical functions
"sine":"function=szinusz: szinusz",
Expand Down Expand Up @@ -225,6 +225,7 @@
"highlight":"postfix=kiemelt",
"least-common-denominator":"function=legkisebb közös nevező",
"rate":"infix=per",
"translation":"function=fordítás",
"constraint":"infix= ; feltétellel; ",

"binomial-coefficient":"infix=választ",
Expand Down
24 changes: 12 additions & 12 deletions tests/Languages/hu/definitions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fn my_set_basic() -> Result<()> {
</math>
"#;

test("hu", "ClearSpeak", expr, "az üres halmaz")?;
test("hu", "ClearSpeak", expr, "a halmaz x vessző, y")?;

Ok(())
}
Expand Down Expand Up @@ -91,7 +91,7 @@ fn set_difference_basic() -> Result<()> {
</math>
"#;

test( "hu", "ClearSpeak", expr, "különbséghalmaz nagy a vessző, nagy b")?;
test( "hu", "ClearSpeak", expr, "különbséghalmaz nagy a és nagy b")?;

Ok(())
}
Expand All @@ -107,7 +107,7 @@ fn postfix_test() -> Result<()> {
<mo>T</mo>
</msup>
"#,
"transzponált x",
"x transzponált",
),
(
"highlight",
Expand Down Expand Up @@ -205,9 +205,9 @@ fn functions_and_inverses_tests() -> Result<()> {

//("fraction", "fraction x over y end fraction"),
("mixed-fraction", "x és y"),
("quotient", "egész rész osztva x vessző, y"),
("quotient", "egész rész x osztva y"),
("evaluated-at", "x értékelve y"),
("remainder", "a maradék, osztva x vessző, y"),
("remainder", "a maradék x osztva y"),

("max", "max x vessző, y vessző, z"),
("min", "min x vessző, y vessző, z"),
Expand All @@ -223,13 +223,13 @@ fn functions_and_inverses_tests() -> Result<()> {

("complex-conjugate", "Komplex konjugált x"),
("complex-arg", "argumentum x"),
("real-part", "valós rész"),
("imaginary-part", "képzetes rész"),
("real-part", "az igazi rész x"),
("imaginary-part", "a képzeletbeli rész x"),

("polar-coordinate", "poláris koordináta x vessző, y"),
("spherical-coordinate", "gömb koordináta x vessző, y vessző, z"),
("cartesian-coordinate", "derékszögű koordináta x vessző, y vessző, z"),
("coordinate", "pont, x vessző y vessző z"),
("coordinate", "koordináta x vessző, y vessző, z"),

("floor", "lépcső x"),
("ceiling", "mennyezet x"),
Expand Down Expand Up @@ -528,7 +528,7 @@ fn statistics_and_probability_tests() -> Result<()> {
("mode", "mód x"),

// conditional probability typically two arguments
// ("conditional-probability", "probability of x given y"),
// ("conditional-probability", "valószínűség x adott y"),
];

for (intent, expected) in tests {
Expand Down Expand Up @@ -576,7 +576,7 @@ fn linear_algebra_tests() -> Result<()> {
("span", "fesztávolság x"),

// transpose supports both postfix and function; we test function explicitly
("transpose", "transzponált x"),
("transpose", "x transzponált"),

// dimensional product is infix
("dimensional-product", "x a(z) y"),
Expand Down Expand Up @@ -727,13 +727,13 @@ fn general_concepts_tests() -> Result<()> {
("permutation-cycle", "permutációs ciklus x"),

// Binary structural / infix-style
// ("ordered-pair", "the pair of x and y"),
("ordered-pair", "a pár x és y"),
("rate", "x per y"),

("binomial-coefficient", "x választ y"),
("embellished-name", "x megjegyzéssel y"),
("indexed-by", "x alsó index y"),
// ("translation", "translation by x comma, y"), // Changes translation to comma
("translation", "fordítás x vessző, y"), // Changes translation to comma
("constraint", "x feltétellel y"),
];

Expand Down