Conversation
|
Ticket title is 'dlck: check object / dkey / akey' |
|
Test stage Unit Test bdev completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-19028/1/display/redirect |
|
Test stage Unit Test with memcheck completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-19028/1/display/redirect |
|
Test stage NLT completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-19028/1/display/redirect |
|
Test stage Unit Test completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-19028/1/display/redirect |
9b9b9fe to
7e44f0d
Compare
Skip-func-vm: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
7e44f0d to
230a3ed
Compare
| void *report_arg) | ||
| { | ||
| if (!btr_ops(tcx)->to_rec_check) { | ||
| return -DER_NOSYS; |
There was a problem hiding this comment.
I would suggest to return 0 if to_rec_check is not registered. The benefits are:
- Do not need NOP
cont_df_rec_check(). - More convenient to use
btr_rec_check()for other non-DLCK purpose in the future.
There was a problem hiding this comment.
What you suggest is very tempting. On the other hand, the current implementation has one very important benefit for me. You have to think about providing the to_rec_check() callback when you call dbtree_check_inplace() on a new class of trees. Otherwise, it is very easy to forget about it.
What do you think?
There was a problem hiding this comment.
As my understand, DLCK usage will generate logs output even if for succeed case, so even if we forget to assign it, we still have way to be aware of that.
Anyway, it is just suggestion.
4 participants
Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-el-9.6-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-hw-test: true
Waits for:
Steps for the author:
After all prior steps are complete: