TST: skip test_reshape under numpy < 2 and dask - #458
Merged
Conversation
The copy=False wrapper does `y.shape = newshape`, and this fails on NumPy < 2 and Dask.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the array-api-tests xfail/skip configuration to avoid running array_api_tests/test_manipulation_functions.py::test_reshape for NumPy < 2 (tested here via 1.22 and 1.26) and for Dask, where the copy=False reshape wrapper relies on y.shape = ... and triggers backend-specific failures.
Changes:
- Add
test_reshapetonumpy-1-22-xfails.txtandnumpy-1-26-xfails.txtwith a note about the scalar/copy=False code path under NumPy < 2. - Add
test_reshapetodask-xfails.txtwith a note that Dask does not support assigning to.shape.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| numpy-1-26-xfails.txt | Adds an xfail/skip entry for test_reshape on NumPy 1.26 due to the copy=False reshape implementation details. |
| numpy-1-22-xfails.txt | Adds an xfail/skip entry for test_reshape on NumPy 1.22 for the same underlying reshape copy=False behavior. |
| dask-xfails.txt | Adds an xfail/skip entry for test_reshape on Dask due to .shape assignment incompatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy=False wrapper does
y.shape = newshape, and this fails on NumPy < 2 and Dask.