fix: define dask reshape copy behavior - #459
Draft
stanbot8 wants to merge 1 commit into
Draft
Conversation
Member
|
This currently swallows copy=False, no? |
stanbot8
marked this pull request as draft
July 29, 2026 22:30
Contributor
Author
|
Yes, it currently treats I've opened a pull request to Dask that adds the I will keep this PR as a draft and update the wrapper to forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared Dask
reshapewrapper fails for scalar and 0-sizecopy=Falsecases.This change routes Dask
reshape(..., copy=False)to the native lazy operation and enables the Array APIreshapetest.This change fixes the Dask issues at issue 446.