BUG: reshape accept an empty array and copy=False - #232
Merged
Conversation
ev-br
reviewed
Jul 28, 2026
| a = asarray(np.ones((2, 3)).T) | ||
| b = reshape(a, (3, 2), copy=True) | ||
| assert_raises(AttributeError, lambda: reshape(a, (2, 3), copy=False)) | ||
| assert_raises(ValueError, lambda: reshape(a, (2, 3), copy=False)) |
Member
There was a problem hiding this comment.
Strictly speaking, a back-compat break. That said, there is no reason for an AttributeError here, and the spec says ValueError, https://data-apis.org/array-api/2022.12/API_specification/generated/array_api.reshape.html
ev-br
approved these changes
Jul 28, 2026
ev-br
changed the title
reshape accept an empty array and copy=False
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reshapewithcopy=Falserejects an empty view.Skip the
shares_memoryview test for an empty array, soreshapewithcopy=Falsereturns the view.Raise
ValueErrorinstead ofAttributeErrorwhen a copy is necessary. The 2025.12 specification requiresValueErrorwhencopy=Falseneeds a copy, and numpy raises the same type.The failing
reshapetest in data-apis/array-api-tests#432 passes with this change.All tests pass.