Skip to content

Add workspace URLs for postgres project, branch, endpoint, and role - #6567

Draft
janniklasrose wants to merge 5 commits into
mainfrom
janniklasrose/postgres-resource-urls
Draft

Add workspace URLs for postgres project, branch, endpoint, and role#6567
janniklasrose wants to merge 5 commits into
mainfrom
janniklasrose/postgres-resource-urls

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Sep 8, 2026

Copy link
Copy Markdown
Member

Caution

CANNOT MERGE - URLs require uid instead of name. Needs redesign. When ready, include snapshots too

Changes

bundle summary previously showed (not deployed) for the URL of Postgres
projects, branches, endpoints, and roles because these resources had no
InitializeURL mapping. Point each at its Lakebase web UI page, using
libs/workspaceurls patterns:

Resource URL
postgres_projects lakebase/{project_name}
postgres_branches lakebase/{branch_name}
postgres_endpoints parent branch's …/computes page
postgres_roles parent branch's …/roles-and-databases page

Projects and branches use their own hierarchical ID. Endpoints and roles
surface under the parent branch, and derive that branch from their own
resolved ID (…/branches/{b}/endpoints/{e}…/branches/{b}) rather than
from the Parent field, which may still hold an unresolved ${...}
reference at summary time.

The URL paths were confirmed with the Postgres team.

Tests

  • TestInitializeURLs extended with a case per resource.
  • Acceptance summary goldens regenerated for the affected postgres_*
    resource and bind tests.

janniklasrose and others added 3 commits September 8, 2026 10:59
These resources previously had no URL in bundle summary. Point each at its
Lakebase page via workspaceurls patterns:

- projects -> lakebase/{project_name}
- branches -> lakebase/{branch_name}
- endpoints -> the parent branch's computes page
- roles     -> the parent branch's roles-and-databases page

Endpoints and roles derive the parent branch from their own resolved ID
rather than the Parent field, which may still hold an unresolved "${...}"
reference at summary time.

Co-authored-by: Isaac <no-reply@databricks.com>
Adding postgres_branches/endpoints/projects/roles to workspaceurls
changes ResourceTypes(); update the experimental open command's expected
list and acceptance golden accordingly.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@janniklasrose
janniklasrose marked this pull request as ready for review September 8, 2026 11:22
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

8 files changed
Suggested: @denik
Also eligible: @pietern, @andrewnester, @shreyas-goenka, @anton-107, @lennartkats-db

/bundle/ - needs approval

6 files changed
Suggested: @denik
Also eligible: @pietern, @andrewnester, @shreyas-goenka, @anton-107, @lennartkats-db

General files (require maintainer)

4 files changed
Based on git history:

  • @denik -- recent work in bundle/config/resources/, .nextchanges/bundles/, acceptance/bundle/deployment/bind/postgres_role/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

They now have workspace URLs, so TestBundleResourcePluralNamesResolveInWorkspaceURLs
requires them to resolve rather than be empty.

Co-authored-by: Isaac <no-reply@databricks.com>
@janniklasrose janniklasrose changed the title Add web UI URLs for postgres project, branch, endpoint, and role Add workspace URLs for postgres project, branch, endpoint, and role Sep 8, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 305c47a

Run: 34222693474

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 303 17 10:00
💚​ aws windows 1 305 15 7:58
💚​ azure linux 1 274 24 8:23
💚​ azure windows 1 276 22 5:43
💚​ gcp linux 1 275 24 8:16
💚​ gcp windows 1 277 22 6:46
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 5 slowest tests (at least 2 minutes):
duration env testname
3:13 aws windows TestAccept
3:10 gcp windows TestAccept
3:08 azure windows TestAccept
2:13 gcp windows TestFilerWorkspaceFilesExtensionsRead
2:09 aws linux TestAccept/bundle/resources/postgres_branches/basic/DATABRICKS_BUNDLE_ENGINE=terraform/DMS=

@janniklasrose
janniklasrose marked this pull request as draft September 8, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants