bundle/artifacts: parallel gzip (pgzip) for the tgz artifact builder - #6577
Open
vinchenzo-db wants to merge 1 commit into
Open
bundle/artifacts: parallel gzip (pgzip) for the tgz artifact builder#6577vinchenzo-db wants to merge 1 commit into
vinchenzo-db wants to merge 1 commit into
Conversation
Both DABs-built tgz paths gzip single-threaded today: tarballFromInclude via compress/gzip and tarballFromGit via git's --format=tar.gz. gzip dominates packaging time on a large tree. Pipe both through klauspost/pgzip (MIT), which spreads compression across cores and still emits an ordinary gzip stream, at the same default level so tarball sizes are unchanged. The tgz artifact is content-addressed on upload, so the compressed bytes must be reproducible. pgzip only parallelizes across fixed-size blocks, so pinning the block size keeps output identical regardless of the build host's core count; TestTarballFromGitIsReproducible guards this. Mirrors the pgzip approach in the air plain_tar packer (#6571), requested by pietern. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 91591fd
Top 7 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both DABs-built tgz paths gzip single-threaded today: tarballFromInclude via compress/gzip and tarballFromGit via git's --format=tar.gz. gzip dominates packaging time on a large tree. Pipe both through klauspost/pgzip (MIT), which spreads compression across cores and still emits an ordinary gzip stream, at the same default level so tarball sizes are unchanged.
The tgz artifact is content-addressed on upload, so the compressed bytes must be reproducible. pgzip only parallelizes across fixed-size blocks, so pinning the block size keeps output identical regardless of the build host's core count; TestTarballFromGitIsReproducible guards this.
Mirrors the pgzip approach in the air plain_tar packer (#6571), requested by pietern.
Changes
Why
Tests