bundle/generate: read recorded state from DMS for in-place generate - #6588
Draft
shreyas-goenka wants to merge 3 commits into
Draft
bundle/generate: read recorded state from DMS for in-place generate#6588shreyas-goenka wants to merge 3 commits into
shreyas-goenka wants to merge 3 commits into
Conversation
The in-place `bundle generate --resource` flow resolved deployed resource IDs from local state, which is only a tombstone when deployment-history recording is on. Read the recorded resources from the deployment metadata service instead via a shared OpenDirectStateForRead helper, so dashboard and genie-space generate work under recording. Enables the DMS acceptance variant for the three generate in-place tests. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: f6a18a9
Top 5 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place
bundle generate --resourceresolved deployed IDs from local state, which is only a tombstone under deployment-history recording. It now reads recorded resources from DMS via a sharedOpenDirectStateForReadhelper, so dashboard/genie-space generate work with recording on. Turns on the DMS acceptance variant for the three generate in-place tests.This pull request and its description were written by Isaac.