Replace hand-written DMS client with the Go SDK - #6591
Draft
shreyas-goenka wants to merge 1 commit into
Draft
Conversation
The libs/dms rawClient hand-wrote CreateVersion, UpdateDeployment, and UpdateOperation because the SDK lacked the operations field, the method, and int64 sequence_id handling. All three are in SDK v0.177.0, so route them through the generated client, using ForceSendFields to keep DMS's masked-but-empty fields on the wire. The testserver fake now reads sequence_id as the number the SDK sends (still emitting a string, like the real service). Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 96b355e
20 interesting tests: 20 flaky
Top 44 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libs/dms rawClient hand-wrote CreateVersion, UpdateDeployment, and UpdateOperation because the SDK lacked the operations field, the method, and int64 sequence_id handling. All three landed in SDK v0.177.0, so this routes them through the generated client, using ForceSendFields to keep DMS's masked-but-empty fields (a cleared deployment_mode, an empty error_message, a staged sequence_id of 0) on the wire. The testserver fake now reads sequence_id as the number the SDK sends and still emits it as a string, like the real service.
This pull request and its description were written by Isaac.