Skip to content

Scope git-pinned AIR snapshots to root_path - #6593

Merged
ben-hansen-db merged 3 commits into
mainfrom
ben/air-git-archive-root-path-scope
Sep 9, 2026
Merged

Scope git-pinned AIR snapshots to root_path#6593
ben-hansen-db merged 3 commits into
mainfrom
ben/air-git-archive-root-path-scope

Conversation

@ben-hansen-db

Copy link
Copy Markdown
Contributor

Changes

Scope git-pinned experimental AIR code snapshots to a subdirectory root_path. Include the subtree in the snapshot cache key and document the behavior in config help.

Why

The Python AIR CLI is gaining the same behavior in universe#2575704. Without this change, the Go CLI archives the entire repository when root_path points to a subdirectory, which can upload a multi-GB monorepo under a misleading directory name.

Tests

  • go test ./experimental/air/cmd
  • go test ./acceptance -run TestAccept/experimental/air/config-help -tail -test.v
  • ./task fmt-q
  • ./task lint-q
  • ./task checks

This PR was written by Codex.

@ben-hansen-db
ben-hansen-db marked this pull request as ready for review September 9, 2026 16:51
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 4df86e7

Run: 34385098969

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 275 16 9:00
💚​ aws windows 1 277 14 7:28
💚​ azure linux 1 274 16 9:22
💚​ azure windows 1 276 14 7:35
💚​ gcp linux 1 275 16 10:02
💚​ gcp windows 1 277 14 7:17
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 11 slowest tests (at least 2 minutes):
duration env testname
4:13 azure windows TestAccept
3:58 aws windows TestAccept
3:46 gcp windows TestAccept
3:15 aws linux TestAccept
3:12 gcp linux TestFilerWorkspaceFilesExtensionsReadDir
2:23 aws windows TestFilerWorkspaceFilesExtensionsStat
2:14 gcp linux TestImportDirDoesNotOverwrite
2:11 azure linux TestAccept
2:10 gcp linux TestAccept
2:05 azure linux TestFilerWorkspaceFilesExtensionsReadDir
2:04 azure linux TestImportDir

@ben-hansen-db
ben-hansen-db added this pull request to the merge queue Sep 9, 2026
@ben-hansen-db
ben-hansen-db removed this pull request from the merge queue due to a manual request Sep 9, 2026
@ben-hansen-db
ben-hansen-db marked this pull request as draft September 9, 2026 17:49
@ben-hansen-db
ben-hansen-db marked this pull request as ready for review September 9, 2026 18:33
@ben-hansen-db
ben-hansen-db added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit bb17864 Sep 9, 2026
34 checks passed
@ben-hansen-db
ben-hansen-db deleted the ben/air-git-archive-root-path-scope branch September 9, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants