Skip to content

ssh: wait for child adoption before releasing the run - #6737

Merged
anton-107 merged 1 commit into
deco-28187-implement-option-as-described-in-26from
ssh-6387-child-adoption-guard
Sep 18, 2026
Merged

anton-107 merged 1 commit into
deco-28187-implement-option-as-described-in-26from
ssh-6387-child-adoption-guard

Conversation

@anton-107

Copy link
Copy Markdown
Contributor

Changes

Add a non-reaping waitid check before releasing the SSH bootstrap run, plus six regression scenarios wired into the SSH Go test suite.

Why

Targets #6387. After SIGTERM, server-group helpers can still parent detached work that the notebook has not adopted yet. An empty survivor scan must not release the run while children remain. The existing SIGCHLD handler retains ownership of exit statuses, and polling/report throttling stay unchanged.

Tests

  • Regression cases fail on the unpatched parent (b3c4b6c3c) and pass with this fix. An isolated Linux process reproduction also verifies delayed adoption and exit-status preservation.
  • ./task fmt, ./task checks, ./task lint, and ./task test-exp-ssh pass.
  • ./task test passes with OMNIGENT unset, cloud testing disabled, and an isolated TMPDIR; two unrelated Terraform acceptance timeouts pass on automatic retry.

This PR was written by Codex.


This PR was created with GitHub MCP.

@github-actions

Copy link
Copy Markdown
Contributor

Waiting for approval

Based on git history, these people are best suited to review:

  • @ilia-db -- recent work in experimental/ssh/internal/client/

Eligible reviewers: @andrewnester, @denik, @janniklasrose, @lennartkats-db, @pietern, @rclarey, @renaudhartert-db, @rugpanov, @shreyas-goenka, @simonfaltum

Suggestions based on git history. See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 136a9e0

Run: 35278488532

Env ✅​pass 🙈​skip Time
✅​ aws linux 276 19 4:10
✅​ aws windows 278 17 4:05
✅​ azure linux 275 19 4:05
✅​ azure windows 277 17 3:41
✅​ gcp linux 276 19 4:16
✅​ gcp windows 278 17 3:53
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:03 aws windows TestAccept
3:50 gcp windows TestAccept
3:39 azure windows TestAccept

@anton-107
anton-107 merged commit 54f4515 into deco-28187-implement-option-as-described-in-26 Sep 18, 2026
24 checks passed
@anton-107
anton-107 deleted the ssh-6387-child-adoption-guard branch September 18, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants