Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 136a9e0
Top 3 slowest tests (at least 2 minutes):
|
anton-107
merged commit Sep 18, 2026
54f4515
into
deco-28187-implement-option-as-described-in-26
24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a non-reaping
waitidcheck before releasing the SSH bootstrap run, plus six regression scenarios wired into the SSH Go test suite.Why
Targets #6387. After SIGTERM, server-group helpers can still parent detached work that the notebook has not adopted yet. An empty survivor scan must not release the run while children remain. The existing SIGCHLD handler retains ownership of exit statuses, and polling/report throttling stay unchanged.
Tests
b3c4b6c3c) and pass with this fix. An isolated Linux process reproduction also verifies delayed adoption and exit-status preservation../task fmt,./task checks,./task lint, and./task test-exp-sshpass../task testpasses withOMNIGENTunset, cloud testing disabled, and an isolatedTMPDIR; two unrelated Terraform acceptance timeouts pass on automatic retry.This PR was written by Codex.
This PR was created with GitHub MCP.