Skip to content

Replace cluster start integration test #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hectorcast-db merged 1 commit into from
Sep 16, 2026
+31 −30
Merged

Replace cluster start integration test #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions databricks-sdk-java/src/test/java/com/databricks/sdk/integration/ClustersIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,12 @@
import com.databricks.sdk.service.compute.ClusterEvent;
import com.databricks.sdk.service.compute.GetEvents;
import java.util.*;
import java.util.concurrent.TimeoutException;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

@EnvContext("workspace")
@ExtendWith(EnvTest.class)
public class ClustersIT {
@Test
void ensuresClusterIsRunning(
WorkspaceClient w, @EnvOrSkip("TEST_DEFAULT_CLUSTER_ID") String clusterId)
throws TimeoutException {
w.clusters().ensureClusterIsRunning(clusterId);
}

@Test
void listsEvents(WorkspaceClient w, @EnvOrSkip("TEST_DEFAULT_CLUSTER_ID") String clusterId) {
Iterable<ClusterEvent> events = w.clusters().events(new GetEvents().setClusterId(clusterId));
Expand Down
53 changes: 31 additions & 22 deletions databricks-sdk-java/src/test/java/com/databricks/sdk/mixin/ClustersExtTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
package com.databricks.sdk.mixin;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.argThat;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import com.databricks.sdk.core.ApiClient;
import com.databricks.sdk.core.DatabricksConfig;
import com.databricks.sdk.core.DummyHttpClient;
import com.databricks.sdk.core.http.Request;
import com.databricks.sdk.core.http.Response;
import com.databricks.sdk.service.compute.*;
import java.net.MalformedURLException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
import java.util.concurrent.TimeoutException;
import java.util.stream.Collectors;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.jupiter.MockitoExtension;
Expand All @@ -23,24 +25,31 @@ class ClustersExtTest {
@Mock ClustersService clustersMock;

@Test
void ensureClusterIsRunning() throws TimeoutException, MalformedURLException {
Request req =
new Request("GET", "https://localhost/api/2.1/clusters/get")
.withQueryParam("cluster_id", "abc");
DummyHttpClient httpClient =
new DummyHttpClient().with(req, new Response("{}", req.getUri().toURL()));

DatabricksConfig config =
new DatabricksConfig()
.setHost("https://localhost")
.setToken("bcd")
.setHttpClient(httpClient);
DatabricksConfig mockConfig = Mockito.spy(config);
Mockito.doReturn(mockConfig).when(mockConfig).resolve();

ClustersExt clustersExt = new ClustersExt(new ApiClient(mockConfig));
void ensureClusterIsRunningStartsTerminatedClusterAndPollsUntilRunning() throws TimeoutException {
when(clustersMock.get(argThat(request -> request.getClusterId().equals("abc"))))
.thenReturn(
new ClusterDetails().setState(State.TERMINATED),
new ClusterDetails().setState(State.PENDING),
new ClusterDetails().setState(State.RUNNING));
ClustersExt clustersExt = new ClustersExt(clustersMock);

clustersExt.ensureClusterIsRunning("abc");

List<String> requests =
Mockito.mockingDetails(clustersMock).getInvocations().stream()
.map(invocation -> invocation.getMethod().getName())
.collect(Collectors.toList());
assertEquals(Arrays.asList("get", "start", "get", "get"), requests);

ArgumentCaptor<GetClusterRequest> getRequests =
ArgumentCaptor.forClass(GetClusterRequest.class);
verify(clustersMock, times(3)).get(getRequests.capture());
assertEquals(
Arrays.asList("abc", "abc", "abc"),
getRequests.getAllValues().stream()
.map(GetClusterRequest::getClusterId)
.collect(Collectors.toList()));
verify(clustersMock).start(argThat(request -> request.getClusterId().equals("abc")));
}

private GetSparkVersionsResponse testGetSparkVersions() {
Expand Down
Loading