fix: preserve reasoning content in chat history - #999
Open
BaygeldiAza wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where assistant reasoning stored in
ChatMessage.thinkingwas reconstructed using the wrong field name.When chat history was rebuilt, the reasoning was sent as
thinkinginstead ofreasoning_content, which could cause thinking-mode requests to fail.Type of change
Changes
reasoning_contentwhen rebuilding chat historyreasoning_contentfor assistant messagesTesting
test_convert_chat_messages_preserves_reasoning_contentRelated issue
Fixes #570