Skip to content

Fix sent message editing interaction - #25

Closed
SuperstructureJH wants to merge 3 commits into
dataelement:mainfrom
SuperstructureJH:codex/edit-sent-message
Closed

Fix sent message editing interaction#25
SuperstructureJH wants to merge 3 commits into
dataelement:mainfrom
SuperstructureJH:codex/edit-sent-message

Conversation

@SuperstructureJH

@SuperstructureJH SuperstructureJH commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • edit only the latest text-only sent user message inline, matching the Codex interaction boundary
  • keep older user messages and steering rows non-editable while preserving their existing actions
  • submit the edited prompt only after confirmation, then replace the visible conversation instead of leaving a second sidebar session
  • preserve workspace, title, and agent preset; clean up temporary revisions on failure

Supersedes #21, which was closed before this interaction correction.

Verification

  • npm ci (patch applies from a clean dependency install)
  • npm test (42 tests passed)
  • npm run typecheck
  • npm run build
  • node --check node_modules/@deepseek-ai/dsh-client-ui-conversation/lib/client.js
  • npm run package:mac:arm64

@SuperstructureJH
SuperstructureJH force-pushed the codex/edit-sent-message branch from 28e8891 to b81a290 Compare August 14, 2026 10:01
@SuperstructureJH
SuperstructureJH marked this pull request as ready for review August 14, 2026 10:02
@yaojin3616

Copy link
Copy Markdown
Contributor

感谢贡献。这个实现基于 Harness 0.1.0-rc.6 的依赖补丁,而当前 main 已升级到 0.1.1-rc.1,旧 patch 已不能安全沿用;同时新版已提供“分支到新对话”的交互,覆盖了主要使用场景。若后续仍需要“编辑已发送消息”的独立体验,应基于新版 Harness 重新设计和实现,因此先关闭这个旧 PR。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants