feat(api): move VPC/VPCAttachment status to condition-based model - #3
Merged
Conversation
Replace the Ready/Identifier bool+string status fields with standard ObservedGeneration + Conditions, add VPCFinalizer, mark VPCSpec immutable after creation, and expand VPCAttachmentStatus with the fields the datapath controller needs to reconcile a single attachment (node, containerID, host/vrf/guest interface names, podSubnet). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ecv
previously approved these changes
Jul 19, 2026
This branch added an XValidation rule making VPCSpec immutable after creation (self == oldSelf), but the vpc-networks-update e2e step still patched an existing VPC's spec.networks and asserted the patch succeeded -- which now fails with "spec is immutable", the cause of the failing E2E Tests check on this PR. Replace the step with reject-vpc-spec-update, asserting the patch is rejected, matching the reject-* pattern used for the other schema constraints in this test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
privateip
marked this pull request as draft
July 19, 2026 21:26
privateip
marked this pull request as ready for review
July 30, 2026 11:55
privateip
requested review from
0xmc,
ecv,
scotwells and
slindseysr
and removed request for
JoseSzycho
July 30, 2026 11:55
slindseysr
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ready bool/Identifier stringstatus fields on VPC and VPCAttachment with the standardObservedGeneration+Conditions []metav1.Conditionpattern.VPCFinalizerand markVPCSpecimmutable after creation (self == oldSelfCEL rule).VPCAttachmentStatuswith the fields needed to reconcile a single attachment:node,containerID,hostInterface,vrfInterface,guestInterface,podSubnet.task generate.Test plan
task buildtask test:unittask lint