feat(api): make VPCAttachment usable as the interface-to-data-plane bridge - #5
Merged
Conversation
…ridge Status becomes partially writable, the spec gains a NetworkInterface back-reference and a master-plugin selector, and a guest that manages its own addressing is now representable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 20, 2026
…plugin interface.mode (Netns | Hypervisor) replaces interface.type (veth | tap), so galactic's plugin names stay out of a cloud-level API, and interfaceRef.uid becomes load-bearing: a mismatch means the attachment is stale. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The controller that writes interfaceRef also sets an owner reference carrying the interface's UID, so the field restated a fact the object already held and owner-reference garbage collection already acts on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
privateip
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VPCAttachmentis the object that connects an NSONetworkInterface, which knows the addresses, to the galactic data plane, which programs them. Today the type cannot serve that role.Status could not be written partially. Eight fields were required, so none could be set without all of them: an identifier could not be recorded before a pod attached, a pending or failed attachment could not be reported through conditions alone, and a guest managing its own addressing could never report at all, since
podSubnetwas required and had to be a CIDR. Onlyconditionsis required now.Spec gains two fields.
interfaceRefnames theNetworkInterfacethis attachment realizes.interface.modeisNetnsorHypervisor— how the guest consumes the NIC, which is the difference between a container and a microVM. It deliberately names no CNI and no Linux device type, so the controller maps it to a plugin and the API does not move when galactic's plugins do.interface.addressesmay now be empty.Two corrections
The
XValidationrule on the spec did not compile — the source contains a U+201D smart quote, andcontroller-genemits it verbatim, so the CRD is rejected on install. The committed CRD had drifted and still showed the old form, which is why it went unnoticed. Removed rather than repaired:vpcis required andVPCRef.Namealready hasMinLength=1.status.vrfInterface's example described the legacy per-attachment VRF name. Galactic made the VRF per-VPC, so the current form isG000000010V.Related
Completes the provider-facing half of datum-cloud/network-services-operator#164 —
NetworkInterface.status.attachmentRefis declared there so "infra providers watch onlyNetworkInterface", andVPCAttachmentis the object it points at. Consumed by datum-cloud/compute#112. Network services integration under datum-cloud/galactic#17.Stacked with #6, which needs these fields.
🤖 Generated with Claude Code