ci: publish the vpc-controller image and kustomize bundle - #7
Merged
Conversation
The repo had no publishing pipeline, so the controller added in #6 could not be deployed anywhere. Add the sibling-standard publish workflow (validate kustomize, build/push the container image, then push the config tree as an OCI kustomize bundle with the image pinned to the same tag). Make the manifests safe to apply in one shot against a live cell: readiness is now gated on the webhook server having started, so the webhook Service takes no endpoint until the controller can admit Pods. The required --attachment-mode moves to an ATTACHMENT_MODE environment variable so an overlay can retarget a cell without rewriting the args list. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
privateip
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VPC controller merged in #6 with a binary and deployment manifests but no way to ship them. This adds the same publishing pipeline the sibling operators use: on every push and release it validates the kustomizations, builds and pushes
ghcr.io/datum-cloud/vpc-controller(amd64 + arm64), then pushesconfig/as an OCI kustomize bundle atghcr.io/datum-cloud/vpc-controller-kustomizewith the image pinned to the same tag. Tags are date-stamped, e.g.v0.0.0-main-20260820-143512. Flux consumes the bundle viaOCIRepositoryand points aKustomizationatconfig/default.Two manifest changes come with it.
--attachment-modeis required and has no default, so it now reads from anATTACHMENT_MODEenvironment variable (defaultHypervisor, correct for Unikraft cells) — a cell overlay patches one env value instead of rewriting an args list by index. And readiness is gated on the webhook server having started, rather than a bare ping.Deployment hazard, first apply on a live cell. The
MutatingWebhookConfigurationshipsfailurePolicy: Failfor Pods labellednetworking.datumapis.com/inject-interfaces: "true". While the controller is not serving, creation of every Pod carrying that label fails. The readiness gate keeps the webhook Service endpoint-less until the controller can actually admit, which turns the failure into a clean connection refusal rather than a silently unattached Pod, but it does not remove the window. cert-manager must be present before this is applied: it issues the serving cert and injects the CA viacert-manager.io/inject-ca-from. If thewebhook-server-certsecret is missing the manager Pod sits inContainerCreatingand the window stays open. On first apply, watch thatCertificate serving-certgoes Ready and that thevpc-controller-webhookService has an endpoint before any labelled workload is scheduled; a Flux health check on the Deployment is the cheapest way to hold the rollout there.Verified:
task build,task test:unit,golangci-lint,yamlfmt -lint,kustomize buildon every kustomization directory, and a local replay of the CI image stamping (kustomize edit set imageinconfig/manager) producing the pinned reference inconfig/default. Not verified: the workflow itself, which cannot run until this is on a branch in CI — including the GHCR push, the bundle artifact and the release-tag path.🤖 Generated with Claude Code