Skip to content

feat: Add the milo-os search plugin at v0.8.0 - #35

Merged
ecv merged 1 commit into
mainfrom
add-search-plugin
Sep 9, 2026
Merged

feat: Add the milo-os search plugin at v0.8.0#35
ecv merged 1 commit into
mainfrom
add-search-plugin

Conversation

@ecv

@ecv ecv commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The search plugin is published only in the Milo catalog, so installing it takes a datumctl plugin index add and the third-party trust prompt that comes with it.

Every other plugin a Datum Cloud user installs comes from this catalog, the one datumctl treats as official and loads with no setup, so search is harder to reach than the rest for no reason a user can see.

This adds it at v0.8.0 across Linux, macOS, and Windows on both architectures, and leaves the Milo listing in place, so the plugin gains a second home rather than moving.

Note

The service repo's release job bumps only the Milo catalog, so this entry will sit at v0.8.0 as search keeps releasing, and wiring a second bump needs a token scoped to this repo.

Test plan

  • datumctl plugin install search works on a machine with no extra catalog registered
  • datumctl search runs on Linux, macOS, and Windows

Requested in review on milo-os/cli-plugins#9 (review)

Related to milo-os/cli-plugins#9

🤖 Generated with Claude Code

https://claude.ai/code/session_011ML5AmU7i7zuSALJitvS8f

The search plugin is published in the Milo catalog, so reaching it takes a
`datumctl plugin index add` and the third-party trust prompt that goes with
it. Every other plugin a Datum Cloud user installs comes from this catalog,
which datumctl treats as official and loads with no setup, so search is
harder to get than its neighbours for no reason a user can see.

Add the manifest at v0.8.0 with all six platform archives, and list it in
the README's plugin table.

The archives carry a `milo-search` binary rather than `datumctl-search`.
datumctl accepts both prefixes, and catalog-installed plugins are stored
under their generic name, so `datumctl search` works either way. The
README's binary-naming note only mentioned the `datumctl-` prefix, so it
now names both.

The entry stays in the Milo catalog too. This is a second listing, not a
move, so milo-os keeps publishing the plugin and this catalog carries it
for Datum Cloud users.

Requested in review on milo-os/cli-plugins#9.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011ML5AmU7i7zuSALJitvS8f
@ecv
ecv requested a review from scotwells September 9, 2026 21:33
@ecv

ecv commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Worth flagging the history here, since you made the call last time. Inventory left this catalog in #20 when the Milo catalog opened, and ipam has only ever been listed there, so search would be the first milo-os plugin to sit in both. I read your review as asking for a second listing rather than reopening that move. If you meant search should live here instead of in the Milo catalog, say so and I will close this and send the removal against milo-os/cli-plugins.

Separately, the green validate on this PR checked nothing. The step that finds changed manifests runs git diff origin/main...HEAD, and actions/checkout leaves no origin/main behind on its shallow single-branch fetch, so the command exits with fatal: bad revision and both later loops iterate over an empty list. Every run in this repo has behaved that way, including the one that admitted the dns plugin.

So I verified by hand instead. The manifest passes ajv against this repo's schema with ajv-formats loaded, and all six archives return 200 with a sha256 matching the v0.8.0 checksums file. Worth noting the schema step would also need -c ajv-formats to run at all, since the uri format makes ajv reject the schema without it.

The Milo catalog fixed the same job in milo-os/cli-plugins#4. Happy to port that here in its own PR if you want it.

@ecv
ecv merged commit a35eb95 into main Sep 9, 2026
2 checks passed
@ecv
ecv deleted the add-search-plugin branch September 9, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants