enhance ReplaceRRSet to track owner UID and generation for accurate record set management - #110
Merged
Merged
Conversation
…on for accurate record set management
fr6nco
marked this pull request as draft
August 26, 2026 12:39
fr6nco
marked this pull request as ready for review
August 26, 2026 12:55
scotwells
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale PowerDNS RRSet reuse when a Kubernetes
DNSRecordSetis deleted and recreated with the same generation.Previously, the PowerDNS sync logic only checked the stored
OBSERVED_GENERATIONcomment and ignored object identity. If a record was deleted and recreated immediately, the new object could have the same generation as the old one but a different UID, and PowerDNS would incorrectly treat the RRSet as already current.This patch stores the Kubernetes object UID in PDNS comments and treats an RRSet as current only when both generation and UID match. Legacy records that only have generation metadata are treated as stale and reconciled on the next pass.
Impact
Contiation of #82