Do not apply omitted completion-generation methods - #2235
Merged
rolandwalker merged 1 commit intoSep 12, 2026
Conversation
Previously, if a completion-generation method was omitted from the completion_match_order configuration value, that method was merely demoted in the priority. With this change, is a method is omitted, then completions based on that method are not generated, and do not appear in the choices visible to the user. Limitation: filename completions don't work well unless "perfect" is in the match-order list, and preferably "slash_words" as well. But realistically, would anyone configure this such that "perfect" matches were omitted?
rolandwalker
deleted the
RW/do-not-apply-omitted-completion-candidate-methods
branch
September 12, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, if a completion-generation method was omitted from the
completion_match_orderconfiguration value, that method was merely demoted in the priority.With this change, is a method is omitted, then completions based on that method are not generated, and do not appear in the choices visible to the user.
Limitation: filename completions don't work well unless
perfectis in the match-order list, and preferablyslash_wordsas well. But realistically, would anyone configure this such that "perfect" matches were omitted?Checklist
changelog.mdfile.AUTHORSfile (or it's already there).