chore: prepare 1.12.0rc4 - #841
Open
axellpadilla wants to merge 3 commits into
Open
axellpadilla wants to merge 3 commits into
axellpadilla wants to merge 3 commits into
Conversation
The skip-path refresh was covered only by a view over a *table* that gained a column. The reported case is a view over a *view* whose column changes type: the child's own SQL never changes, so its CREATE is skipped, and a view caches the types it resolved at CREATE time just as it caches a `select *` expansion. Verified against SQL Server 2022: with the skip path restored to its former no-op the parent correctly reports `int` while the child still reports `varchar`; with `sp_refreshview` in place both report `int`. Closes #838 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 411121a)
The entry described only a view over a table that gained, lost or reordered columns. The same cache also holds column *types*, which is how the fix was reported: a child view kept serving `varchar` after its parent view's column became `int`. Say so, and link the issue. Closes #838 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares
1.12.0rc4and closes out #838.Closes #838
Contents
test(view): cover a child view whose parent view changes column type— the skip-pathsp_refreshviewfix (fe82935,d8ca5ce) already landed onmasterfor 1.12, but its coverage was a view over a table that gained a column. Child views show stale data types when parent view is updated #838 reports the view-over-view case, where a column changes type: the child's own SQL never changes, so itsCREATEis skipped, and a view caches the types it resolved atCREATEtime just as it caches aselect *expansion. This adds that test.docs(changelog): name the child-view symptom on the skipped-view refresh— the existing entry described only added/dropped/reordered columns. Same cache, also holds types; the entry now says so and links the issue.chore: prepare 1.12.0rc4 release—__version__.pyfrom1.12.0rc3to1.12.0rc4, which is whatverify_version.pychecks the release tag against.The 1.11 line gets the fix itself in the companion backport PR, which also bumps to
1.11.2rc1.Verification
Against SQL Server 2022 in the devcontainer:
tests/functional/adapter/mssql/test_materialize_change.py— 9 passedpython .github/scripts/verify_version.py v1.12.0rc4— OKintwhile the child still reportsvarchar(AssertionError: assert 'varchar' == 'int'). Withsp_refreshviewin place, both reportint.🤖 Generated with Claude Code