Avoid storage exceptions when localStorage is unavailable - #1056
Open
ryanchou1994 wants to merge 1 commit into
Open
Avoid storage exceptions when localStorage is unavailable#1056ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a web worker,
localStorageis absent. Loading the browser adapter and enabling or disabling a namespace currently throws caught exceptions while looking up storage and calling its methods. With “Pause on caught exceptions” enabled, these interrupt debugging even though the operations otherwise succeed.Check whether
localStorageandexports.storageexist before accessing them. Keep the existing exception handling for environments where storage exists but access is denied, and retain theprocess.env.DEBUGfallback.Fixes #954.
The regression test observes actual caught exceptions through Node's inspector and includes a positive control to verify that the debugger is observing them. Additional tests cover available storage, a denied global getter, failing storage methods and the environment fallback.
Validation:
npm testpasses on macOS and Linux with Node 22.23.2: 20 Node tests, 14 real headless-browser tests and lint. The 16 existing lint warnings remain.Browser checks use isolated profiles and local fixtures. Windows, Firefox and Safari were not tested locally.