Fix WithGroup metric option being silently ignored - #129
Open
riptide-01 wants to merge 4 commits into
Open
Conversation
…e return types for MetricOperations functions Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
WithGroup metric option being silently ignored
riptide-01
marked this pull request as ready for review
August 17, 2026 07:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
operation.WithGroup()is the only public way for a Go hook to assign a metric to a group, but it never actually took effect. The option method was declared on a value receiver, so the assignment mutated a copy of the operation and was thrown away, even though the collector correctly applies options through a pointer.Tests
Before:

After:
