Skip to content

fix: capture S3 diagnostics and stop logging presigned URLs on SQL cache failures - #114

Draft
tkislan wants to merge 5 commits into
mainfrom
fix/113-sql-cache-upload-diagnostics
Draft

fix: capture S3 diagnostics and stop logging presigned URLs on SQL cache failures#114
tkislan wants to merge 5 commits into
mainfrom
fix/113-sql-cache-upload-diagnostics

refactor: tighten SQL cache comments and upload error logging

c424f02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 5, 2026 in 0s

74.93% (+0.50%) compared to 6198101

View this Pull Request on Codecov

74.93% (+0.50%) compared to 6198101

Details

Codecov Report

❌ Patch coverage is 95.31250% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.93%. Comparing base (6198101) to head (c424f02).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deepnote_toolkit/sql/sql_cache_diagnostics.py 95.23% 3 Missing and 1 partial ⚠️
deepnote_toolkit/sql/sql_execution.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   74.42%   74.93%   +0.50%     
==========================================
  Files          95       96       +1     
  Lines        5704     5808     +104     
  Branches      850      862      +12     
==========================================
+ Hits         4245     4352     +107     
+ Misses       1182     1177       -5     
- Partials      277      279       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.