Make unexpected warnings test failures#292
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterwarnings = ["error"]to the pytest config, so any unexpected warning during the suite is a test failure. Warnings are load-bearing API in 2.0 (the multi-word-entryUserWarning, the facade deprecation warnings), and without this a warning regression is invisible — the eight spurious warnings on restoring a 1.4Constantspickle shipped all the way to the final PR Post-rc1 API polish: StrEnum Role, Parser conveniences, dead-vocabulary repair #290 review this way, with 2,393 tests green around it.pytest.warnsor a localsimplefilter("error")block), so no ignore entries and no test changes were needed. The list stays a bare"error"— the narrowest possible end state.--rootdir; a scratchpad-rooted run silently skipspyproject.toml— noted for anyone re-verifying), and the guard reaches--doctest-modulesitems too.Test Plan
uv run pytest -q— 2393 passed, 5 skipped, 11 xfailed (identical to baseline)uv run mypy/uv run ruff check nameparser/cleanuv run sphinx-build -b doctest docs— 177 tests, 0 failureswarnings.warnin a test file fails the run🤖 Generated with Claude Code