fix(client): continue connection discovery after HTTP errors - #146
Merged
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
webfansplz
marked this pull request as draft
July 28, 2026 16:34
There was a problem hiding this comment.
Pull request overview
This PR improves the resiliency of the devframe client’s connection-meta discovery by treating non-2xx HTTP responses as failures (so the client can continue trying other candidate base URLs), and updates tests to cover the new behavior.
Changes:
- Check
Response.okand throw on non-success HTTP status before attempting to parse__connection.json. - Update existing tests to stub
fetchwithok/statusand add a regression test ensuring fallback to the next base URL on HTTP error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devframe/src/client/rpc.ts | Adds explicit response.ok handling during connection-meta discovery to allow fallback across bases on HTTP errors. |
| packages/devframe/src/client/rpc.test.ts | Adjusts fetch stubs for ok/status and adds a test that asserts fallback behavior when the first base returns a non-OK response. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
webfansplz
marked this pull request as ready for review
July 28, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be related to vitejs/devtools#494