fix(hub): inherit environment in PTY sessions - #147
Merged
Conversation
- Preserve PATH and parent environment variables when spawning PTYs - Add native PTY regression coverage for inherited variables Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR fixes interactive PTY terminal sessions in @devframes/hub by ensuring spawned PTY processes inherit the parent process environment (notably PATH), while keeping the terminal defaults and allowing explicit caller overrides.
Changes:
- Update PTY spawn options to include
...process.envwhen constructing the PTY environment. - Preserve existing PTY defaults (
TERM,COLORTERM,FORCE_COLOR) and keepexecuteOptions.envas the highest-precedence override. - Add a native PTY regression test verifying environment inheritance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hub/src/node/host-terminals.ts | Ensures PTY sessions inherit the parent environment while preserving defaults and caller overrides. |
| packages/hub/src/node/tests/host-terminals.test.ts | Adds a native PTY test to prevent regressions in environment inheritance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
antfu
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
startPtySessionreplaced the complete process environment with terminal-specific variables. Commands launched by name consequently lostPATH, causing the PTY child to exit without output and leaving consumers with a blank terminal.Validation
pnpm lintpnpm typecheckpnpm run test -- --run(891 tests)@uxanalytics/vite-helperssuite (482 tests)