Skip to content

Task/implement dynamic variables in map tooltip - #146

Merged
ralvarez-dg merged 7 commits into
mainfrom
task/implement-dynamic-variables-in-map-tooltip
Aug 6, 2026
Merged

Task/implement dynamic variables in map tooltip#146
ralvarez-dg merged 7 commits into
mainfrom
task/implement-dynamic-variables-in-map-tooltip

Conversation

@timothygachengo

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (BREAKING CHANGE:)
  • Refactor / chore (refactor: / chore:)
  • Documentation update (docs:)

Affected package(s)

  • @devgateway/dvz-wp-commons
  • @devgateway/create-wp-customizer
  • @devgateway/upgrade-wp-customizer
  • plugins/wp-react-blocks-plugin
  • plugins/wp-react-custom-api
  • plugins/wp-react-custom-rest-menu
  • Other plugin / theme / Docker (no changeset needed)

Checklist

  • PR title follows Conventional Commits format
  • pnpm build passes locally
  • No hardcoded credentials, internal URLs, client names, or PII introduced
  • Any new dependency has a GPL-2.0-or-later-compatible license (MIT, BSD, Apache-2.0, ISC are all compatible)

Copilot AI review requested due to automatic review settings August 6, 2026 11:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds editor-side guidance for using dynamic variables in map tooltips and extends the map block’s dimension configuration to support a third (optional) dimension, with corresponding serialization updates. The PR also modifies the GitHub pre-release tagging workflow.

Changes:

  • Add dynamic variable “guide” UI in the Map block tooltip settings (API vs CSV variants).
  • Add dimension3 support across map block attributes, editor config, and saved markup.
  • Update release/tagging workflow branch rules for pre-releases.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js Introduces tooltip variable guides and updates tooltip settings UI.
plugins/wp-react-blocks-plugin/blocks/map/README.md Documents new tooltipValueVariables attribute.
plugins/wp-react-blocks-plugin/blocks/map/index.js Changes dimension2 default and adds dimension3 attribute.
plugins/wp-react-blocks-plugin/blocks/map/BlockSave.js Serializes dimension3 (and attempts to introduce tooltipValueVariables) into saved markup.
plugins/wp-react-blocks-plugin/blocks/map/BlockEdit.js Updates editor-side handling for 3 dimensions; adds a debug console.log.
plugins/wp-react-blocks-plugin/blocks/map/APIConfig.js Adds a UI control for selecting dimension3.
.github/workflows/build-and-pre-release-wordpress.yml Changes tag-action branch matching / release configuration.
Suppressed comments (2)

plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js:53

  • Same issue here: style keys like "margin-top" / "font-style" are not valid in React style props and will be ignored. Use camelCase (marginTop, fontStyle, fontSize).
            style={{
              "margin-top": "4px",
              "font-size": "12px",
              "font-style": "normal",
              color: "rgb(117, 117, 117)",

plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js:127

  • CSVTooltipGuide also uses invalid React style keys ("font-size"), so the guidance text styling may not apply. Prefer fontSize.
      <PanelRow>
        <span style={{ "font-size": "11px" }}>
          Location -&gt; {"{locationName}"}
        </span>
      </PanelRow>

Comment thread plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js
Comment thread plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js
Comment thread plugins/wp-react-blocks-plugin/blocks/map/APIConfig.js Outdated
Comment thread plugins/wp-react-blocks-plugin/blocks/map/BlockEdit.js
Comment thread plugins/wp-react-blocks-plugin/blocks/map/BlockSave.js
Comment thread plugins/wp-react-blocks-plugin/blocks/map/index.js
Comment thread plugins/wp-react-blocks-plugin/blocks/map/index.js
Comment thread .github/workflows/build-and-pre-release-wordpress.yml
timothygachengo and others added 4 commits August 6, 2026 15:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ralvarez-dg
ralvarez-dg merged commit 7896c99 into main Aug 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants