Task/implement dynamic variables in map tooltip - #146
Merged
ralvarez-dg merged 7 commits intoAug 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds editor-side guidance for using dynamic variables in map tooltips and extends the map block’s dimension configuration to support a third (optional) dimension, with corresponding serialization updates. The PR also modifies the GitHub pre-release tagging workflow.
Changes:
- Add dynamic variable “guide” UI in the Map block tooltip settings (API vs CSV variants).
- Add
dimension3support across map block attributes, editor config, and saved markup. - Update release/tagging workflow branch rules for pre-releases.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js | Introduces tooltip variable guides and updates tooltip settings UI. |
| plugins/wp-react-blocks-plugin/blocks/map/README.md | Documents new tooltipValueVariables attribute. |
| plugins/wp-react-blocks-plugin/blocks/map/index.js | Changes dimension2 default and adds dimension3 attribute. |
| plugins/wp-react-blocks-plugin/blocks/map/BlockSave.js | Serializes dimension3 (and attempts to introduce tooltipValueVariables) into saved markup. |
| plugins/wp-react-blocks-plugin/blocks/map/BlockEdit.js | Updates editor-side handling for 3 dimensions; adds a debug console.log. |
| plugins/wp-react-blocks-plugin/blocks/map/APIConfig.js | Adds a UI control for selecting dimension3. |
| .github/workflows/build-and-pre-release-wordpress.yml | Changes tag-action branch matching / release configuration. |
Suppressed comments (2)
plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js:53
- Same issue here: style keys like "margin-top" / "font-style" are not valid in React style props and will be ignored. Use camelCase (marginTop, fontStyle, fontSize).
style={{
"margin-top": "4px",
"font-size": "12px",
"font-style": "normal",
color: "rgb(117, 117, 117)",
plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js:127
- CSVTooltipGuide also uses invalid React style keys ("font-size"), so the guidance text styling may not apply. Prefer fontSize.
<PanelRow>
<span style={{ "font-size": "11px" }}>
Location -> {"{locationName}"}
</span>
</PanelRow>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ralvarez-dg
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-wp-commons@devgateway/create-wp-customizer@devgateway/upgrade-wp-customizerplugins/wp-react-blocks-pluginplugins/wp-react-custom-apiplugins/wp-react-custom-rest-menuChecklist
pnpm buildpasses locally