Skip to content

test: cover the OpenSSL preflight and build-error surfacing under zsh #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devhardiyanto merged 1 commit into from
Jul 28, 2026
Merged

test: cover the OpenSSL preflight and build-error surfacing under zsh #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions tests/linux/zsh-smoke.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,25 @@ check() { # check <name> <expected-substring> <actual>
fi
}

check_status() { # check_status <name> <expected> <actual>
if [[ "$3" == "$2" ]]; then
print "ok - $1"
else
print "FAIL - $1 (expected status $2, got $3)"
fail=1
fi
}

check_empty() { # check_empty <name> <actual>
if [[ -z "$2" ]]; then
print "ok - $1"
else
print "FAIL - $1"
print " expected no output, got: $2"
fail=1
fi
}

tmp=$(mktemp -d)
export PHPVM_DIR="$tmp/phpvm"
export PHPVM_NO_UPDATE_CHECK=1
Expand Down Expand Up @@ -70,6 +89,41 @@ mkdir -p "$PHPVM_DIR/versions/8.5.1" "$PHPVM_DIR/versions/8.5.2" "$PHPVM_DIR/ver
out=$(_phpvm_older_patch_hint 8.5.8 2>&1)
check "joins older patches with ', '" "8.5.1, 8.5.2" "$out"

print -r -- "-- build preflight (OpenSSL guard) --"
# Pin the probe so the result doesn't depend on whatever the runner has.
_phpvm_openssl_version() { print "3.0.2" }

out=$(_phpvm_check_openssl_compat 7.3.33 2>&1); st=$?
check "blocks PHP 7.3 on OpenSSL 3" "cannot be built against OpenSSL 3.0.2" "$out"
check_status "blocks with a non-zero status" 1 $st
check "names the remedy" "phpvm install 8.1" "$out"
check "names the bypass" "PHPVM_SKIP_OPENSSL_CHECK=1" "$out"

_phpvm_check_openssl_compat 8.3.10 >/dev/null 2>&1
check_status "allows PHP 8.3 on OpenSSL 3" 0 $?

_phpvm_openssl_version() { return 1 }
_phpvm_check_openssl_compat 7.3.33 >/dev/null 2>&1
check_status "fails open when OpenSSL cannot be probed" 0 $?

_phpvm_openssl_version() { print "3.0.2" }
PHPVM_SKIP_OPENSSL_CHECK=1 _phpvm_check_openssl_compat 7.3.33 >/dev/null 2>&1
check_status "honours PHPVM_SKIP_OPENSSL_CHECK" 0 $?

print -r -- "-- build-log error surfacing --"
export PHPVM_LOG="$tmp/build.log"
print "ext/openssl/openssl.c:1491:58: error: RSA_SSLV23_PADDING undeclared" > "$PHPVM_LOG"
out=$(_phpvm_show_build_error 2>&1)
check "surfaces the first compiler error" "RSA_SSLV23_PADDING" "$out"

print "configure: error: libxml-2.0 not met" > "$PHPVM_LOG"
out=$(_phpvm_show_build_error 2>&1)
check "surfaces a configure error" "libxml-2.0" "$out"

print "all good" > "$PHPVM_LOG"
out=$(_phpvm_show_build_error 2>&1)
check_empty "stays quiet when the log holds no error" "$out"

rm -rf "$tmp"

print ""
Expand Down
Loading