fix: register tsx's ESM loader only so mocha 12.0.1 can load find-up@8 - #157
Merged
Merged
Conversation
Bare `tsx` also patches the CJS resolver, which turns an ESM dependency's `import` into a `require`. Mocha 12.0.1 bumped find-up 5 -> 8 (ESM-only), whose unicorn-magic dependency exports nothing under the `require` condition, so the suite died with ERR_PACKAGE_PATH_NOT_EXPORTED before running a test. `tsx/esm` registers just the ESM loader and leaves the require(esm) path to Node. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare
tsxalso patches the CJS resolver, which turns an ESM dependency'simportinto arequire. Mocha 12.0.1 bumped find-up 5 -> 8 (ESM-only), whose unicorn-magic dependency exports nothing under therequirecondition, so the suite died with ERR_PACKAGE_PATH_NOT_EXPORTED before running a test.tsx/esmregisters just the ESM loader and leaves the require(esm) path to Node.What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test