create ide.code-workspace - #97
Open
QuangAnhLe wants to merge 1 commit into
Open
QuangAnhLe wants to merge 1 commit into
QuangAnhLe wants to merge 1 commit into
Conversation
hohwille
requested changes
Sep 14, 2026
Member
There was a problem hiding this comment.
@QuangAnhLe thanks for bringing this story forward.
However, I am confused how this could ever have worked.
BTW: Does our JSON merger support this so we will get multiple objects in the folders array? How would he know if an entry already exists or a new one needs to be added?
Please read:
- https://github.com/devonfw/IDEasy/blob/main/documentation/configurator.adoc#how-it-works
- https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/commit.adoc (you should always provide a description to issues and PRs so users can understand what this is about and which issue this is connected to, if you also don't follow the commit conventions then nobody can know which issue this PR is related to and what is the reason for this change).
| @@ -0,0 +1,5 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
I do not understand the filename ide.code-workspace: There is no such file used by visual studio code.
Our merger needs to use the path and the filename of the files as used by the IDE (here vscode) relative to the top-level configuration path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.