Add crossOrigin, onLoad and onLoadFailed options to IntercomProvider - #835
Merged
Conversation
Set the crossorigin attribute on the messenger <script> tag and detect when the messenger script loads or fails to load. Reconciles the original work with the current initialize() signature (cspNonce) and adds Cypress e2e coverage. Adapted from #675 by Marc Knaup (@fluidsonic). Co-Authored-By: Marc Knaup <85242+fluidsonic@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: fbcf07b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +152 B (+2.67%) Total Size: 5.85 kB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three IntercomProvider options:
Supersedes #675
Continues @fluidsonic's work in #675, preserving authorship via Co-Authored-By. We couldn't push onto that branch: it lives on an organization-owned fork where GitHub doesn't offer "Allow edits by maintainers" (maintainerCanModify is false), so the required rebase couldn't be applied there. Recreated on a maintainer-owned branch, rebased onto current main and reconciled with the newer cspNonce argument in initialize(). Please close #675 in favour of this PR.
Notes
Verification
🤖 Generated with Claude Code