Support mcstructure format version 2 - #5
Open
HashimTheArab wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mcstructurefiles using format version 2 and NBT int-array block layers-1Evidence
Minecraft Preview 26.50.24 documents the v2 format: https://feedback.minecraft.net/hc/en-us/articles/47907593889677-Minecraft-Beta-Preview-26-50-24
Lens verification against client 1.26.50.26 found the matching read, write, and format-bound routines at RVAs
0x79f7050,0x79f9cb0, and0x79f7430. The exact-version implementation accepts one or two v2 layers, reads them asTAG_IntArray, and writes the second layer only when it contains a non--1index. BDS 1.26.50.25 independently showed the same behavior.Validation
bastion/mobs/hoglin.mcstructureand rewrote it as v2 with oneTAG_IntArraylayerTAG_IntArraygo test ./... -count=1(builds successfully; repository has no test files)go vet ./...git diff --check