Skip to content

feat: Certification versions V27 and V28 - #332

Open
schneiderstefan wants to merge 3 commits into
mainfrom
stschnei/v27-v28
Open

feat: Certification versions V27 and V28#332
schneiderstefan wants to merge 3 commits into
mainfrom
stschnei/v27-v28

Conversation

@schneiderstefan

Copy link
Copy Markdown

Update to the specifications related to the new last_install_timestamp and canister_creation_timestamp leaves in the state tree.

Update to the specifications related to the new `last_install_timestamp`
and `canister_creation_timestamp` leaves in the state tree.
@schneiderstefan
schneiderstefan requested review from a team as code owners July 29, 2026 07:31
@github-actions github-actions Bot added the interface-spec Changes to the IC interface specification label Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

🤖 Here's your preview: https://yvncx-qyaaa-aaaam-aeiqa-cai.icp0.io

@mraszyk mraszyk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be less confusing in my opinion if last_install_timestamp is cleared whenever the canister is uninstalled.

@schneiderstefan

Copy link
Copy Markdown
Author

It'd be less confusing in my opinion if last_install_timestamp is cleared whenever the canister is uninstalled.

But it is. The field is missing if the canister is not installed.

@mraszyk

mraszyk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The field is missing if the canister is not installed.

{ "last_install_timestamp" : S.last_install_timestamp[canister_id] | if C ≠ EmptyCanister } indeed prunes the field from the certified state tree if the canister is empty. But I'd still set last_install_timestamp[A.canister_id] = (deleted) in the transitions that uninstall code to avoid confusion.

@schneiderstefan

Copy link
Copy Markdown
Author

Oh I see. Sorry I didn't understand the suggestion at first. I added this now. Also, I added that the two fields get deleted when the canister gets deleted, along with the environment variables, which were also missing.

@mraszyk

mraszyk commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I fixed a few more places and the PR looks good to me, but I'll only approve it once the replica code changes is rolled out (to prevent accidental merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interface-spec Changes to the IC interface specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants