feat: Expose the project canister ID table to sync plugins - #720
Draft
adamspofford-dfinity wants to merge 3 commits into
Draft
feat: Expose the project canister ID table to sync plugins#720adamspofford-dfinity wants to merge 3 commits into
adamspofford-dfinity wants to merge 3 commits into
Conversation
adamspofford-dfinity
force-pushed
the
spofford/plugin-canister-mappings
branch
from
August 20, 2026 16:38
56cc6ff to
b4d5ccf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes environment-specific canister ID mappings to sync plugins.
Changes:
- Extends the plugin WIT input with canister ID entries.
- Builds aliases for canisters in the same subproject.
- Refactors plugin execution parameters and updates documentation/tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
docs/concepts/sync-plugins.md |
Documents the new input table. |
crates/icp/src/canister/sync/script.rs |
Updates test parameters. |
crates/icp/src/canister/sync/plugin.rs |
Builds and forwards the exposed ID table. |
crates/icp/src/canister/sync/mod.rs |
Adds the syncing canister’s store key. |
crates/icp-sync-plugin/sync-plugin.wit |
Extends the plugin ABI. |
crates/icp-sync-plugin/src/runtime.rs |
Passes IDs through PluginInvocation. |
crates/icp-sync-plugin/src/lib.rs |
Exports PluginInvocation. |
crates/icp-sync-plugin/DESIGN.md |
Updates runtime design documentation. |
crates/icp-cli/src/operations/sync.rs |
Supplies the canister store key. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The `canister-ids` table is informational; `canister-call` always targets the canister being synced. The field and rationale docs described a call-target / dependency-declaration permission mechanism that does not exist in this interface, which could mislead plugin authors into expecting they can call other canisters from the table. State the real restriction instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets plugins access canister ID mappings (regardless of dependency declarations).
Stack created with GitHub Stacks CLI • Give Feedback 💬