refactor: route all operation progress through a new icp-events crate

[raymondk]

Supersedes #709, which landed the same inversion as one change. This PR reaches the same end state through four reviewable slices (one commit each), each keeping the full test suite green and pinning output parity against the existing integration tests along the way.

Why

Progress reporting is what welded the operations layer to the terminal: operations constructed ProgressManagers, drove indicatif bars, formatted user-facing strings, and printed batch failure dumps, while the Build/Synchronize ports in crates/icp took a tokio::sync::mpsc::Sender<String> that only existed because the binary had a progress bar to feed.

What

New crates/icp-events: typed, serde::Serialize events (TaskStarted/StepStarted/Output/Progress/StepCompleted/TaskCompleted, with typed TaskKind payloads per operation) and cheap-clone emitter handles (Reporter → TaskReporter → StepReporter). Sends are sync and non-blocking; with no receiver they are no-ops, so tests and headless callers need no wiring. Errors stay on the operations' Result path — TaskOutcome::Failed carries display data only.

New crates/icp-cli/src/render/: the presentation layer. InteractiveRenderer reproduces the existing indicatif UX (spinners, step headers, rolling output window, byte bars for snapshot transfers, deferred failure dumps — absorbing MultiStepProgressBar::dump_output); PlainRenderer covers --debug. Commands drive a renderer per operation phase via rendered() / rendered_task().

Push-down: Build, Synchronize, ScriptRunner, and the sync-plugin runtime's run_plugin take a StepReporter in place of Option<Sender<String>> — no Option, a null reporter instead. The plugin runtime's live output forwarding becomes lossless (events instead of best-effort try_send).

Commit chain (intended to be reviewed commit by commit, merged unsquashed):

1. icp-events crate + renderers + the build pipeline end to end
2. sync pipeline: trait push-down into icp and icp-sync-plugin, temporary line-channel bridges deleted, retained plugin stderr and failure cause chains modeled as outcome data
3. deploy's single-action phases (create/install/settings/env-vars/Candid check) + the rendered() helper; no ProgressManager left in operations or deploy
4. snapshot byte transfers: Progress { position } events and renderer-owned byte bars

Notes for review

• Output parity is pinned by the existing build_tests/sync_tests exact-format assertions; the only test edits are the tracing-target renames (icp::progress: → icp::render::plain:).
• One deliberate behavior change: under --debug, snapshot transfer bars no longer draw (previously they ignored the debug flag); --debug output is now consistent across all commands.
• Network commands' spinners and migrate_id's status spinner are command-owned UX and intentionally stay direct — commands are the presentation layer.
• Events serialize with stable naming from day one, so a streaming --json renderer (RFC: document --json output schemas in --help and/or generated docs #493) is purely additive later.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QUZHfx2ng97WM2j9XoA3rr

[Copilot]

Pull request overview

Introduces typed operation-progress events and CLI-owned renderers, decoupling core operations from terminal presentation.

Changes:

• Adds the icp-events event and reporter API.
• Routes build, sync, deploy, and snapshot progress through renderers.
• Replaces output channels and operation-owned progress bars.

Reviewed changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Cargo.toml	Registers icp-events.
Cargo.lock	Locks new dependencies.
crates/icp-events/Cargo.toml	Defines the events crate.
crates/icp-events/src/lib.rs	Implements events and reporters.
crates/icp/Cargo.toml	Adds events dependency.
crates/icp/src/canister/wasm.rs	Reports WASM resolution events.
crates/icp/src/canister/script.rs	Streams script output through reporters.
crates/icp/src/canister/build/mod.rs	Updates the build interface.
crates/icp/src/canister/build/script.rs	Reports script-build output.
crates/icp/src/canister/build/prebuilt.rs	Reports prebuilt-WASM progress.
crates/icp/src/canister/sync/mod.rs	Updates the synchronization interface.
crates/icp/src/canister/sync/script.rs	Updates script-runner reporting.
crates/icp/src/canister/sync/plugin.rs	Passes reporters into plugins.
crates/icp-sync-plugin/Cargo.toml	Adds events dependency.
crates/icp-sync-plugin/src/runtime.rs	Emits typed plugin output.
crates/icp-cli/Cargo.toml	Adds events dependency.
crates/icp-cli/src/main.rs	Registers the render module.
crates/icp-cli/src/progress.rs	Removes migrated multi-step rendering.
crates/icp-cli/src/render/mod.rs	Adds renderer orchestration and logging.
crates/icp-cli/src/render/plain.rs	Adds debug-mode rendering.
crates/icp-cli/src/render/interactive.rs	Adds interactive progress rendering.
crates/icp-cli/src/operations/build.rs	Emits build task events.
crates/icp-cli/src/operations/sync.rs	Emits sync task events.
crates/icp-cli/src/operations/install.rs	Emits installation events.
crates/icp-cli/src/operations/settings.rs	Emits settings-update events.
crates/icp-cli/src/operations/binding_env_vars.rs	Emits environment-update events.
crates/icp-cli/src/operations/candid_compat.rs	Emits compatibility-check events.
crates/icp-cli/src/operations/bundle.rs	Uses event-driven builds.
crates/icp-cli/src/operations/snapshot_transfer.rs	Emits byte positions.
crates/icp-cli/src/commands/build.rs	Runs builds with a renderer.
crates/icp-cli/src/commands/sync.rs	Runs sync with a renderer.
crates/icp-cli/src/commands/deploy.rs	Renders deploy phases.
crates/icp-cli/src/commands/project/bundle.rs	Renders bundle builds.
crates/icp-cli/src/commands/canister/snapshot/upload.rs	Renders upload progress.
crates/icp-cli/src/commands/canister/snapshot/download.rs	Renders download progress.
crates/icp-cli/tests/build_tests.rs	Updates tracing targets.
crates/icp-cli/tests/sync_tests.rs	Updates tracing targets.

Suppressed comments (1)

crates/icp-cli/src/render/interactive.rs:65

• The spinner is inserted into MultiProgress before its prefix and initial message are set. This reintroduces the unlabeled first-frame race described in the superseded implementation: configure the detached bar fully, add it, and only then start the ticker.

                        let bar = self.multi_progress.add(
                            ProgressBar::new_spinner()
                                .with_style(make_style(TICK_EMPTY, COLOR_REGULAR)),
                        );
                        bar.set_prefix(format!("[{}]", task.canister()));

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.