Initial file structure setup. - #1
Merged
Merged
Conversation
BigBlueHat
requested changes
Aug 4, 2026
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
Still reviewing, but the const stuff seems necessary.
Update the name across repo.
dlongley
approved these changes
Aug 7, 2026
| @@ -0,0 +1,45 @@ | |||
| { | |||
| "name": "@digitalbazaar/vc-html-render-method", | |||
| "version": "0.1.0", | |||
Member
There was a problem hiding this comment.
This might need to be set to something else prior to initial release for our tooling, I can't remember, so just making a note.
dlongley
reviewed
Aug 7, 2026
Comment on lines
+254
to
+258
| } catch(e) { | ||
| // surface listener errors globally without breaking the emit loop | ||
| setTimeout(() => { | ||
| throw e; | ||
| }); |
Member
There was a problem hiding this comment.
We should consider changing this uncatchable error pattern. I'll turn this into an issue.
- Fix most zizmor issues. - Update actions. - Update workflow name.
BigBlueHat
reviewed
Aug 7, 2026
BigBlueHat
left a comment
BigBlueHat
left a comment
There was a problem hiding this comment.
I didn't get this review in in time, apparently. I'll make an issue...
| return `<!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta http-equiv="content-security-policy" content="${TEMPLATE_CSP}"> |
There was a problem hiding this comment.
Suggested change
| <meta http-equiv="content-security-policy" content="${TEMPLATE_CSP}"> | |
| <meta http-equiv="content-security-policy" content="${TEMPLATE_CSP}"> | |
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> |
We need the "wrapper code" to set the viewport for responsive display, so breakpoints can be used in CSS, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.