Remove --align-crop stereo auto-alignment feature - #36
Open
disk02 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the stereo auto-alignment pipeline end to end: the --align-crop click option and its align_crop parameters through render_gaussians, render_gaussians_pred_space, _render_stereo_outputs, and _finalize_sbs_frame; the now-unused render_encode_prepare timing wrapper; the cv2-only align-crop test plus its _disk_frame helper; and the entire src/sharp/utils/stereo_align.py module (sole lazy-OpenCV consumer).
Kept intact: _align_for_compare (fast-preview center-crop) and models/alignment.py (depth alignment).
Verified: zero new ruff findings vs base (4 removed detections, all from the deleted module); py_compile OK on all touched files; residue grep (align_crop/stereo_align/AlignParams/auto_align_and_crop/warp_and_crop) returns 0 hits.