Skip to content

Prevent premature drafter structured output - #117

Merged
aheritier merged 1 commit into
mainfrom
fix/drafter-tool-output
Sep 15, 2026
Merged

aheritier merged 1 commit into
mainfrom
fix/drafter-tool-output

Conversation

@aheritier

Copy link
Copy Markdown
Collaborator

Summary

  • switch the PR-review drafter to tool-mode structured output so mid-analysis narration cannot be treated as its terminal result
  • upgrade the agent config to v16 and document the terminal __structured_output__ contract
  • add YAML contract coverage and correct reusable-workflow permission guidance

Why

Native structured output is applied to every Anthropic completion. A drafter progress message can therefore be schema-shaped and returned as a final empty/incomplete draft, as observed in docker/sailor#2325. Tool mode ends the drafter only on its explicit, schema-valid output-tool call.

Validation

  • focused PR-review agent YAML tests (71 passed)
  • pnpm test (1,054 passed)
  • pnpm lint
  • docker-agent v1.140.0 dry-run config validation

No security, authorization, fail-closed, marker, or retry safeguards were weakened.

@aheritier
aheritier requested a review from dgageot September 15, 2026 14:23
@aheritier
aheritier merged commit cb05915 into main Sep 15, 2026
15 checks passed
@aheritier
aheritier deleted the fix/drafter-tool-output branch September 15, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants