daemon-config invalid JSON on Windows runners

[willat8]

Contributing guidelines

• I've read the contributing guidelines and wholeheartedly agree

I've found a bug, and:

• The documentation does not mention anything about my problem
• There are no open or closed issues that are related to my problem

Description

When using daemon-config on a Windows runner, the config file gets rendered without any double quotes and so is invalid JSON. The config then gets ignored when the daemon starts so it's quite tricky to tell what's going on.

Example:

with:
  daemon-config: |
    {
      "experimental": true
    }

Becomes { experimental: true } in daemon.json.

Expected behaviour

For daemon-config to render valid JSON.

Actual behaviour

Invalid JSON.

Repository URL

No response

Workflow run URL

No response

YAML workflow

---

Workflow logs

No response

Docker daemon logs

Additional info

No response

[slonopotamus]

Also hit this issue: https://github.com/slonopotamus/ue-docker-ng/actions/runs/32239837585/job/96027771588

From job logs:

Install Docker daemon service
  C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -Sta -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "& 'D:\a\_temp\docker-actions-toolkit-lJfDQL\docker-asset-1h4caw-docker-setup-win.ps1' -ToolDir 'C:\hostedtoolcache\windows\docker-archive-stable\29.7.2\x64' -RunDir 'C:\Users\runneradmin\setup-docker-action\run-bba313d4' -DockerHostSocket 'npipe:////./pipe/setup_docker_action' -DaemonConfig '{  features: {    containerd-snapshotter: true  }}'"

Note no quotes around containerd-snapshotter.

This leads to containerd-snapshotter not working.

[slonopotamus]

@crazy-max how to use updated actions-toolkit code? Do we need to wait for a new release of setup-docker-action?

[crazy-max]

@slonopotamus Yes new release of setup-docker-action, keep you posted