Skip to content

fix(chatroom): remove positive tabindex from composer input (#270) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Voyagerroc-Lab wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix(chatroom): remove positive tabindex from composer input (#270) #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/webapp/cypress/e2e/chatroom/send-and-retry.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('chatroom send and retry', () => {
})

it('sends a message and renders it', () => {
cy.get('[data-testid="composer-input"]').type('hello from cypress')
cy.get('[data-testid="composer-input"] [contenteditable="true"]').type('hello from cypress')
cy.get('[data-testid="composer-primary-action"]').click()
cy.contains('hello from cypress').should('be.visible')
})
Expand All @@ -17,7 +17,7 @@ describe('chatroom send and retry', () => {
statusCode: 401,
body: { code: '42501' }
}).as('failedSend')
cy.get('[data-testid="composer-input"]').type('this will fail')
cy.get('[data-testid="composer-input"] [contenteditable="true"]').type('this will fail')
cy.get('[data-testid="composer-primary-action"]').click()
cy.wait('@failedSend')
cy.get('[data-status="failed"]').should('be.visible')
Expand All @@ -29,7 +29,7 @@ describe('chatroom send and retry', () => {
statusCode: 409,
body: { code: '23505', message: 'duplicate key value violates unique constraint' }
}).as('dupSend')
cy.get('[data-testid="composer-input"]').type('idempotent send')
cy.get('[data-testid="composer-input"] [contenteditable="true"]').type('idempotent send')
cy.get('[data-testid="composer-primary-action"]').click()
cy.wait('@dupSend')
cy.get('[data-status="sent"]').should('exist')
Expand Down
4 changes: 1 addition & 3 deletions apps/webapp/src/components/chatroom/components/MessageComposer/components/Input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@ export const Input = ({ className }: { className?: string }) => {
'text-base-content flex min-w-0 flex-1 items-center self-center',
rowHeight,
className
)}
tabIndex={1}>
)}>
<EditorContent
id="chatroom-editor"
data-testid="composer-input"
tabIndex={2}
ref={editorRef}
className={twMerge(
'text-base-content max-h-52 w-full overflow-y-auto break-words wrap-anywhere whitespace-pre-line',
Expand Down