Skip to content

Correct handler class name and route name separator in routing page - #26

Merged
arhimede merged 1 commit into
mainfrom
correct-routing-page-class-and-route-name
Sep 15, 2026
Merged

arhimede merged 1 commit into
mainfrom
correct-routing-page-class-and-route-name

Conversation

@arhimede

Copy link
Copy Markdown
Member

The routing page documented a class that no longer exists and a route name that throws when used.

  • PageHandler was renamed to GetPageViewHandler in release 1.2.0, but both the prose and the code sample still used the old name.
  • The code sample iterated $moduleName and wrapped the handler in an array; the current src/Page/src/RoutesDelegator.php iterates $prefix and passes the handler unwrapped. The sample now matches the source verbatim.
  • The route name was given as page.about. The separator is ::, so url('page.about') throws — request-lifecycle.md already had it right and the two pages contradicted each other.
  • The claim that every module loops over config routes was wrong: only Page does. App registers a single static / route, which is now shown.

Signed-off-by: arhimede <julian@dotkernel.com>
@arhimede
arhimede requested a review from bidi47 September 15, 2026 17:34
@arhimede
arhimede merged commit 64e0d8f into main Sep 15, 2026
7 checks passed
@alexmerlin
alexmerlin deleted the correct-routing-page-class-and-route-name branch September 16, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants