Skip to content

[installer] Refresh Android SDK manifest - #12476

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-update-android-installer-feed
Aug 24, 2026
Merged

[installer] Refresh Android SDK manifest#12476
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-update-android-installer-feed

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

This PR is stacked on #12442.

Testing

  • built Xamarin.Installer.Build.Tasks.csproj
  • built Xamarin.Installer.AndroidSDK.csproj
  • validated the edited XML files

Copilot AI lite review requested due to automatic review settings August 21, 2026 13:26
@jonathanpeppers jonathanpeppers changed the title jonathanpeppers update android installer feed [installer] Refresh Android SDK manifest Aug 21, 2026
@jonathanpeppers
jonathanpeppers force-pushed the jonathanpeppers-update-android-installer-feed branch from 4579cb3 to acf0a84 Compare August 21, 2026 13:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the installer-side Android SDK manifest feed and default version properties so the installer can fetch newer Android SDK components (platform-tools and platform APIs) aligned with the repo’s pinned SDK revisions.

Changes:

  • Bumps installer defaults to Platform-Tools 37.0.1 and platform android-37.0 (Xamarin.Installer.Common.props).
  • Adds Platform-Tools 37.0.0/37.0.1 and Emulator 37.1.11 entries to the d18.0 manifest feed.
  • Aligns platform entries with pinned platform revisions, adding Android 37.1 and updating the 33–37 platform package set (including *-ext* platform IDs where applicable).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Xamarin.Installer.Build.Tasks/Xamarin.Installer.Common.props Updates default installer SDK component versions (platform-tools + platform).
src/Xamarin.Installer.AndroidSDK/Feeds/AndroidManifestFeed_d18.0.xml Refreshes the installer manifest feed with newer platform-tools, emulator, and platform packages/revisions.
Suppressed comments (1)

src/Xamarin.Installer.AndroidSDK/Feeds/AndroidManifestFeed_d18.0.xml:797

  • ⚠️ The obsolete="True" marker in this manifest is currently not honored by the XamarinRepository parser: ParseCommonPackageData() reads the path attribute and calls AsBool() instead of reading the obsolete attribute. As a result, changes like marking platforms;android-34 obsolete here won’t actually cause it to be treated as obsolete (and filtered out by default).

Consider fixing src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK/Xamarin/XamarinRepository.cs to read obsolete (similar to the JDK parsing path) so the manifest’s obsolete flags have the intended effect.

	<platform revision="2" path="platforms;android-34" filesystem-path="platforms/android-34" manifest-url="https://dl.google.com/android/repository/repository2-3.xml" description="Android SDK Platform 34" obsolete="True" preview="False" license="android-sdk-license" original-type="sdk:platformDetailsType" api="34" version="0.0.0" codename="" min-tools-rev="0" layoutlib-api="15" layoutlib-revision="0">

Base automatically changed from skill-runner/androidsdk-20260819-dd770c0aeb0b7269 to main August 24, 2026 08:34
Add current platform-tools, Android 37 platforms, and Emulator 37.1.11 while retaining older feed entries. Align installer defaults with Platform Tools 37.0.1 and Android 37.0.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: bd318154-87a3-4df1-b9d9-6fd4c57e9de3
@simonrozsival
simonrozsival force-pushed the jonathanpeppers-update-android-installer-feed branch from acf0a84 to e3c0afe Compare August 24, 2026 08:35
@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Aug 24, 2026
@jonathanpeppers
jonathanpeppers merged commit c7fd1b1 into main Aug 24, 2026
45 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-update-android-installer-feed branch August 24, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants