Skip to content

Centralize agentic workflow firewall allowlist - #12493

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-workflow-firewall-allowlist
Aug 24, 2026
Merged

Centralize agentic workflow firewall allowlist#12493
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-workflow-firewall-allowlist

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • centralize network approvals for all agentic workflows in a shared import
  • allow the blocked aka.ms and Azure Application Insights domains
  • simplify covered Google, Microsoft, Android, Azure DevOps, and VS Assets entries

Validation

  • gh aw compile <workflow> --strict for Android PR Reviewer, Nightly Fix Finder, and Skill Runner

Copilot AI lite review requested due to automatic review settings August 24, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centralizes network firewall approvals for three agentic workflows and regenerates their lock files.

Changes:

  • Adds a shared network allowlist.
  • Updates Android Reviewer, Nightly Fix Finder, and Skill Runner to import it.
  • Regenerates the corresponding lock manifests.
  • Moderate issue: retain bare microsoft.com and vsassets.io entries alongside wildcards, then regenerate all three lock files.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Summary
.github/workflows/skill-runner.md Imports the shared network allowlist.
.github/workflows/skill-runner.lock.yml Regenerated compiled workflow; requires regeneration after the allowlist fix.
.github/workflows/shared/network-allowlist.md Defines shared domains; wildcard entries currently omit apex hosts.
.github/workflows/nightly-fix-finder.md Imports the shared network allowlist.
.github/workflows/nightly-fix-finder.lock.yml Regenerated compiled workflow; requires regeneration after the allowlist fix.
.github/workflows/android-reviewer.md Imports the shared network allowlist.
.github/workflows/android-reviewer.lock.yml Regenerated compiled workflow; requires regeneration after the allowlist fix.

Comment thread .github/workflows/shared/network-allowlist.md
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2a57582a-a01e-4423-9aab-f36011be7696
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2a57582a-a01e-4423-9aab-f36011be7696
@jonathanpeppers
jonathanpeppers force-pushed the jonathanpeppers-workflow-firewall-allowlist branch from 6f95266 to a6dcd77 Compare August 24, 2026 13:52
@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Aug 24, 2026
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 24, 2026 16:45
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared allowlist preserves each workflow's required domains, the documented wildcard semantics cover apex hosts, and all three generated lock files match the centralized source configuration.

@jonathanpeppers
jonathanpeppers merged commit 5315b73 into main Aug 24, 2026
44 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-workflow-firewall-allowlist branch August 24, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants